Fix cluster call responses that are missing source fields #118642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change usage from `_source: 'true'` to `_source: true`.
jportner
added
v8.0.0
release_note:skip
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Nov 16, 2021
pgayvallet
approved these changes
Nov 16, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 16, 2021
…8642) Change usage from `_source: 'true'` to `_source: true`.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
Tomas also recommended our v7 usage from Seeing as we will be supporting the 7.16 branch for the foreseeable future, and this bug was not trivial to diagnose, I'll backport it to 7.16 as well. |
kibanamachine
added a commit
that referenced
this pull request
Nov 16, 2021
…118698) Change usage from `_source: 'true'` to `_source: true`. Co-authored-by: Joe Portner <[email protected]>
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Change usage from `_source: 'true'` to `_source: true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #118639.
Change usage from
_source: 'true'to_source: true.This is an unreleased regression that appears to have been caused by the recent upgrade of the
elasticsearch-jsclient upgrade to the 8.0 version.To test, you can:
incrementCountermethod of the saved objects repository and verify that the periodic calls toincrementCounterare getting a response that contains source fields