Fix modals in react (#11714) #11862
Merged
Fix modals in react (#11714) #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix focused button not being set Need to do it in a timeout because ng-react hasn’t loaded the react code yet, so it can’t find the buttons. * add a test that would have caught the issue, and also change the default focused button for the listing delete page since it’s a destructive action. * Add a comment * Push focusing of default button into react code * Push ESC key handling into react as well * Remove ESC tests in angular form They don’t pass, I’m guessing because of the way it’s triggered, but these test cases should now be handled in jest. Also confirmed it works as expected with the modal. * Address code review comments * Use autoFocus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to do it in a timeout because ng-react hasn’t loaded the react
code yet, so it can’t find the buttons.
that would have caught the issue, and also change the default focused
button for the listing delete page since it’s a destructive action.
Add a comment
Push focusing of default button into react code
Push ESC key handling into react as well
Remove ESC tests in angular form
They don’t pass, I’m guessing because of the way it’s triggered, but
these test cases should now be handled in jest. Also confirmed it
works as expected with the modal.
Address code review comments
Use autoFocus
backports #11714