[Lens] Add Multi terms support to Top Values

[dej611]

Summary

Fix #95079

This PR introduces an interface for Lens of the Multi terms value aggregation, via the Top Values function.
This PR does not contain the Combine drag and drop action. Will be added in a follow up PR.

When a new term field is added the current fields used are removed from the field dropdown list.
When more than one field is defined scripted fields are filtered from the field dropdown list, and where already set are marked as invalid with an explanation (both in the workspace and in the panel) on how to fix it.

Time shift conflict is resolved similarly for the single term, concatenating conditions of multiple terms:

Terms can be reordered manually via Drag and Drop:

The empty field can be reordered as well but it has no effect until it contains a value. Closing and reopening the panel when empty will just discard it:

In case of 2 fields, where only one is filled with a value, the trash icon will be enabled only for the empty one:

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[ghudgins]

Will list things here as I find them:

• couldn't filter when left clicking multi terms in a stacked bar, it just filters time. Expected the "Select filters to apply" modal with checkbox choices
• I wish legend truncation was better automatically - all multi fields are going to likely run into the 1 line fast

[dej611]

@elasticmachine merge upstream

[kibanamachine]

merge conflict between base and head

[mbondyra]

The issues I mentioned before are all fixed. One small thing to correct (here or in the next PR if you prefer to:)

• dropping a filed to 2-fields multifield replaces the first field. Not sure if that's desired behavior. Maybe instead we should replace the whole dimension with a new top values?

one.mp4

• when switching between top values and filters we make a default filter with the field from top values. For multi values, we only do it for the first field. Maybe it's worth to expand it to all fields?

two.mp4

[dej611]

• dropping a filed to 2-fields multifield replaces the first field. Not sure if that's desired behavior. Maybe instead we should replace the whole dimension with a new top values?

The drag and drop behaviour has not be considered in this PR yet, but I have prepared a follow up PR which adds a combine action on drop, plus other drop handlers: #119841
I'll make sure to add a test case on that branch for this replace scenario.

• when switching between top values and filters we make a default filter with the field from top values. For multi values, we only do it for the first field. Maybe it's worth to expand it to all fields?

This is definitely a bug in this PR. Will address it.

[dej611]

I'd leave the option and keep > as default (note whitespaces around it)

@Dosant I've updated the default char in the formatter.
Right now I've just replaced the single char: do you prefer having a full string replacement instead?

const separator = params.separator ?? ' > '

• dropping a filed to 2-fields multifield replaces the first field. Not sure if that's desired behavior. Maybe instead we should replace the whole dimension with a new top values?

I've tested this behaviour also in th linked PR and it was a full bug. Fixed the behaviour plus one more unit test for it. 👍

when switching between top values and filters we make a default filter with the field from top values. For multi values, we only do it for the first field. Maybe it's worth to expand it to all fields?

Also addressed this, adding tests on the filters side.

[Dosant]

I'd leave the option and keep > as default (note whitespaces around it)

@Dosant I've updated the default char in the formatter. Right now I've just replaced the single char: do you prefer having a full string replacement instead?

const separator = params.separator ?? ' > '

const separator = params.separator ?? ' > '

is more flexible, so I'd keep as it was :D

[dej611]

@Dosant restored the previous version + added a couple of unit tests.

[stratoula]

@dej611 while the legend is not truncated for xy charts

for the partition charts is truncated. Is this intended?

[stratoula]

I am approving as I have only found this minor issue. Feel free to merge when this is solved! What a lovely PR 👏

[dej611]

@stratoula refactored the truncation logic into a shared helper and added few tests for it.
Now XY, Pie and Heatmap charts use the shared function for truncation default.

[flash1293]

@elasticmachine merge upstream

[flash1293]

@elasticmachine merge upstream

[kibanamachine]

merge conflict between base and head

[mbondyra]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 66dab0d
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
lens	727	732	+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2904	2905	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.1MB	1.1MB	+8.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	442.9KB	443.3KB	+338.0B

Unknown metric groups

API count

id	before	after	diff
data	3318	3319	+1

History

• 💛 Build #11861 was flaky a4ce3b7
• 💚 Build #11648 succeeded fbffc53
• 💚 Build #11039 succeeded decdf29
• 💔 Build #11003 failed 30f7fe6
• 💚 Build #10710 succeeded 99d2dda
• 💚 Build #10645 succeeded c506802

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream