-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Output API endpoints #118589
[Fleet] Output API endpoints #118589
Conversation
Pinging @elastic/fleet (Team:Fleet) |
85ffbc2
to
7d4f0f1
Compare
7d4f0f1
to
ad02252
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -226,6 +226,11 @@ class OutputService { | |||
`Preconfigured output ${id} cannot be deleted outside of kibana config file.` | |||
); | |||
} | |||
|
|||
if (originalOutput.is_default && !fromPreconfiguration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_default_monitoring
check is not needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good catch we should probably not allow to delete the default monitoring too 👍
.expect(200); | ||
|
||
expect(deleteResponse.id).to.eql(outputId); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see tests for attempting to delete default outputs
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Metrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Nicolas Chaulet <[email protected]>
Summary
Related to #117317
This PR create the missing Output endpoints needed for the multiple output UI:
POST /outputs
to create a new output.DELETE /outputs/{id}
to delete an existing output. (You cannot delete the default output).I also added some integration test to cover these endpoints, and updated the openAPI spec.