Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle transient Elasticsearch errors during package installation #118587

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Nov 15, 2021

Summary

Fixes #111859

This adds a simple wrapper around each ES operation we execute during package installation only. It does not wrap any operations that are not idempotent, for example, data stream rollovers.

Checklist

Delete any items that are not applicable to this PR.

@joshdover joshdover added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 29, 2021
@joshdover joshdover marked this pull request as ready for review November 29, 2021 15:49
@joshdover joshdover requested a review from a team as a code owner November 29, 2021 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover requested a review from kpollich November 29, 2021 15:49
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Super easy to follow - thanks for the work here!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Handle common transient errors during package installs with a retry
5 participants