Adjust user management functional tests to work in Cloud. #118315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
test
Team:Security
azasypkin
force-pushed
the
issue-63276-cloud-user-tests
branch
from
6b44a8d to
f488f91
Compare
azasypkin
force-pushed
the
issue-63276-cloud-user-tests
branch
from
f488f91 to
b93e9f0
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-security (Team:Security) |
azasypkin
added
auto-backport
thomheymann
reviewed
Nov 17, 2021
|
|
||
| // In Cloud default users are defined in file realm, such users aren't exposed through the Users API. | ||
| if (isCloudEnvironment()) { | ||
| expect(Object.keys(users)).to.eql(['test_user']); |
There was a problem hiding this comment.
Can this change? Is there a skipCloud tag we could use similar to skipFirefox?
There was a problem hiding this comment.
Is there a skipCloud tag we could use similar to skipFirefox?
There is skipCloud, but it'd still be beneficial to test the Cloud default users (or lack thereof). I think what we need is onlyCloud so that we can have a separate test suite for the Cloud, but afaik we don't have this yet.
thomheymann
approved these changes
Nov 17, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2021
…118860) Co-authored-by: Aleh Zasypkin <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2021
…118861) Co-authored-by: Aleh Zasypkin <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of our user management functional tests are failing when run against Cloud deployment. The reason is that default users in Cloud are defined in the file realm and hence not returned from the users APIs.
It turned out that we already tried to fix this test to work in Cloud using the workaround (
config.get('servers.elasticsearch.hostname') !== 'localhost'), but the test broke again when the Cloud disabled anonymous access by default.In this PR I'm reusing the same Cloud-detection workaround and updating the test.
Blocked: We cannot verify fix at the moment, 8.1.0-SHANPSHOT is failing in Cloud and latest 7.16.0-SNAPSHOT doesn't include #118413 yet.The tests with the same fix have passed on 7.16 branch (link is internal, ping me and I'll share the link),Fixes: #63276