[Logs UI] Replace KIP with data views in user facing copy #118307
Conversation
Kerry350
added
v8.0.0
Feature:Logs UI
|
💚 CLA has been signed |
|
@elasticmachine merge upstream |
…/kibana into 100852-change-kip-to-data-views
| @@ -83,6 +83,6 @@ export const IndexPatternSelector: React.FC<{ | |||
| }; | |||
|
|
|||
| const indexPatternSelectorPlaceholder = i18n.translate( | |||
There was a problem hiding this comment.
This is tricky but should we rename these variables as well?
I made some changes recently to remove IndexPattern types that were recently deprecated but I didn't rename the variables/functions because there were just so many occurrences so I don't know how we handle this.
There was a problem hiding this comment.
It's a good question. I tried (for the most part) to leave variables etc alone. They definitely need updating but I think it'd make more sense to make a followup issue and do it all in one go. Reason being there's quite a lot of changes to be made in the server side code (especially where we have the "resolver" code). This way we can tick off our box on #100844 ASAP.
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
@elasticmachine merge upstream |
|
@miltonhultgren Thanks for the review. I've moved it out of draft now, but there's no extra changes. Will merge once this build goes green. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Kerry350 |
…8307) * Change user facing copy from index pattern to data view
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…118566) * Change user facing copy from index pattern to data view Co-authored-by: Kerry Gallagher <[email protected]>
…8307) * Change user facing copy from index pattern to data view
* Change user facing copy from index pattern to data view
Summary
Fixes #100852.
This just updates the user facing copy (and a couple of bits of code that were right alongside the copy).