Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Move settings to their own tab #117919

Merged
merged 3 commits into from
Nov 9, 2021
Merged

[Fleet] Move settings to their own tab #117919

merged 3 commits into from
Nov 9, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 8, 2021 •
edited
Loading

Summary

As part of the multiple output UI we are moving the settings to their own tab #117317

Move the settings tab from a Flyout to a new tab in the Fleet application,

  • all the links should have been updated too.
  • I removed the useUrlModal hook as it's not use anymore

UI Changes

Screen Shot 2021-11-09 at 9 18 27 AM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 8, 2021
@nchaulet nchaulet self-assigned this Nov 8, 2021
@nchaulet nchaulet marked this pull request as ready for review November 9, 2021 14:20
@nchaulet nchaulet requested a review from a team as a code owner November 9, 2021 14:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet commented Nov 9, 2021
View reviewed changes
.../fleet/public/applications/fleet/sections/settings/components/legacy_settings_form/index.tsx
@@ -9,16 +9,12 @@ import React, { useEffect, useCallback } from 'react';
import styled from 'styled-components';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just the old settings flyout, that will be removed in coming PRs for multiple output UI

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default Firefox Tests / Spaces app Enter Space allows user to navigate to different spaces, respecting the configured default route

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1123 1124 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 615.1KB 614.5KB -608.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 105.2KB 104.8KB -401.0B
Unknown metric groups

API count

id before after diff
fleet 1225 1226 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

criamico
criamico approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

kpollich
kpollich approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nchaulet nchaulet merged commit 54fe3c5 into elastic:main Nov 9, 2021
@nchaulet nchaulet deleted the feature-117317-move-settings-to-their-tab branch November 9, 2021 18:09
@kibanamachine kibanamachine mentioned this pull request Nov 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
@nchaulet @kibanamachine
[Fleet] Move settings to their own tab (elastic#117919)
e448a59
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 9, 2021
@kibanamachine @nchaulet
[Fleet] Move settings to their own tab (#117919) (#118064)
9f0aae0 
Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibanamachine @kpollich @criamico