Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable Embeddable Supports Ephemeral Sort #117742

Merged
merged 13 commits into from
Nov 11, 2021
Merged

Datatable Embeddable Supports Ephemeral Sort #117742

merged 13 commits into from
Nov 11, 2021

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Nov 5, 2021 •
edited
Loading

Summary

Resolves #114625

Screen.Recording.2021-11-05.at.3.55.47.PM.mov

Responsive:
Screen Shot 2021-11-10 at 1 22 08 PM

Checklist

Delete any items that are not applicable to this PR.

@drewdaemon drewdaemon requested a review from flash1293 November 5, 2021 21:48
@drewdaemon drewdaemon added Feature:Lens Team:DataVis Team label for DataVis Team v8.1.0 labels Nov 5, 2021
@drewdaemon drewdaemon force-pushed the 114625/datatable-embeddable-supports-column-sorting branch from f0a973b to 4385eba Compare November 9, 2021 22:18
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review November 10, 2021 01:22
@drewdaemon drewdaemon requested a review from a team as a code owner November 10, 2021 01:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Team:DataVis)

@drewdaemon drewdaemon added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:DataVis Team label for DataVis Team labels Nov 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@drewdaemon drewdaemon force-pushed the 114625/datatable-embeddable-supports-column-sorting branch from cbcd4ff to 88aa21c Compare November 10, 2021 18:49
flash1293
flash1293 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works as expected. Thanks for this change, it's a great building block for other interaction related functionality we might want to expose in the dashboard later on!

x-pack/plugins/lens/public/embeddable/embeddable.tsx Outdated Show resolved Hide resolved
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Docker CI Group / endpoint When on the Endpoint Policy Details Page when on Ingest Policy Edit Package Policy page should preserve updates done from the Fleet form

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 955.7KB 956.4KB +703.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 43.2KB 43.3KB +115.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 36a82e4 into elastic:main Nov 11, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 15, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117742 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 15, 2021
@drewdaemon drewdaemon deleted the 114625/datatable-embeddable-supports-column-sorting branch November 22, 2021 14:21
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@drewdaemon @dmlemeshko
Datatable Embeddable Supports Ephemeral Sort (#117742)
b5bc707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Allow sorting on dashboard edit & view
4 participants
@drewdaemon @elasticmachine @kibanamachine @flash1293