-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] [Exploratory View] adjust yaxis mode according to field format #117646
[Observability] [Exploratory View] adjust yaxis mode according to field format #117646
Conversation
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, @awahab07 or @lucasfcosta can one of you please do a functionality review on this. I am trying to do less work on kibana side this week.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
Summary
Fixes #117096
Fixes #116683
In exploratory view mutli series, we can have two y axis as the same time. Each y axis is formatted in a specific way according to the field format specified in the Data View. However, metrics in multi series were sometimes attributed to the wrong yaxis, resulting in incorrect formatting in the data displayed in the chart and in the popover.
Some background: the field format for the first column is what will be used by default for the right axis. When a metric is added that does not match the formatting for the first column, a second y axis is added.
So to resolve this issue, we check if the field format for the column matches the field format for the first column. If so, we can safely attribute this column to the right y axis. If not, we can assume it fits the left y axis.
Testing
Navigate to exploratory view
Select the
KPI over time
report type.Add a series with synthetics data type and monitor duration metric
Add two more series, both with synthetics data type and down pings/up pings metric.
Ensure that the up/down pings are displayed as number without formatting, and the monitor duration is displayed as a duration with units
You can play around with next removing all series, then adding them back again in the opposite order, starting with down/up pings and ending with monitor duration. The popover format should still remain accurate.
You can continue to check different synthetics/rum metrics and their formatting. Ensure that the expected value is what is displayed in the tooltip