Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] [Exploratory View] adjust yaxis mode according to field format #117646

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Nov 5, 2021

Summary

Fixes #117096
Fixes #116683

In exploratory view mutli series, we can have two y axis as the same time. Each y axis is formatted in a specific way according to the field format specified in the Data View. However, metrics in multi series were sometimes attributed to the wrong yaxis, resulting in incorrect formatting in the data displayed in the chart and in the popover.

Screen Shot 2021-10-28 at 9 39 57 AM

Some background: the field format for the first column is what will be used by default for the right axis. When a metric is added that does not match the formatting for the first column, a second y axis is added.

Screen Shot 2021-11-05 at 7 16 52 AM

So to resolve this issue, we check if the field format for the column matches the field format for the first column. If so, we can safely attribute this column to the right y axis. If not, we can assume it fits the left y axis.

Testing

Navigate to exploratory view
Select the KPI over time report type.
Add a series with synthetics data type and monitor duration metric
Add two more series, both with synthetics data type and down pings/up pings metric.
Ensure that the up/down pings are displayed as number without formatting, and the monitor duration is displayed as a duration with units
You can play around with next removing all series, then adding them back again in the opposite order, starting with down/up pings and ending with monitor duration. The popover format should still remain accurate.
You can continue to check different synthetics/rum metrics and their formatting. Ensure that the expected value is what is displayed in the tooltip

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Nov 5, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner November 5, 2021 12:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, @awahab07 or @lucasfcosta can one of you please do a functionality review on this. I am trying to do less work on kibana side this week.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 377.0KB 377.3KB +258.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality Looks good as well
image

@dominiqueclarke dominiqueclarke merged commit b7173dd into elastic:main Nov 9, 2021
@dominiqueclarke dominiqueclarke deleted the fix/exploratory-view-lens-yaxis-formatters branch November 9, 2021 12:53
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 9, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Dominique Clarke <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 9, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Dominique Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 v8.1.0
Projects
None yet
4 participants