[Security Solution] show correct failed transform on failed transform banner #117608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
added
v8.0.0
release_note:skip
joeypoon
force-pushed
the
fix/failed-transform-banner-id
branch
from
1ce3fb7 to
7d7565b
Compare
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
pzl
approved these changes
Nov 5, 2021
| <> | ||
| <FormattedMessage | ||
| id="xpack.securitySolution.endpoint.list.transformFailed.message" | ||
| defaultMessage="A required transform, {transformId}, is currently failing. Most of the time this can be fixed by {transformsPage}. For additional help, please visit the {docsPage}" | ||
| values={{ | ||
| transformId: metadataTransformStats[0]?.id || metadataTransformPrefix, | ||
| transformId: failingTransformIds || metadataTransformPrefix, |
There was a problem hiding this comment.
heh, I guess this made sense when we only had one
|
@joeypoon this looks awesome - can you also update the docs link to this? https://www.elastic.co/guide/en/security/7.16/ts-management.html This provides more focused troubleshooting instructions |
academo
approved these changes
Nov 5, 2021
joeypoon
force-pushed
the
fix/failed-transform-banner-id
branch
from
7d7565b to
f26fade
Compare
joeypoon
force-pushed
the
fix/failed-transform-banner-id
branch
from
f26fade to
243af9f
Compare
joeypoon
force-pushed
the
fix/failed-transform-banner-id
branch
from
243af9f to
23a04d2
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kevinlog
approved these changes
Nov 5, 2021
TinaHeiligers
approved these changes
Nov 5, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2021
… banner (#117608) (#117738) Co-authored-by: Joey F. Poon <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2021
… banner (#117608) (#117739) Co-authored-by: Joey F. Poon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Endpoint list failed transform banner was always only showing the first transform id even if it wasn't failing. It will now display the correct failing transform(s).
only united transform is stopped:
shows name of failing united transform:
Checklist
For maintainers