Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] fix crosshair theme and style issues #117323

Merged
merged 4 commits into from
Nov 3, 2021
Merged

[8.0] fix crosshair theme and style issues #117323

merged 4 commits into from
Nov 3, 2021

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Nov 3, 2021 •
edited
Loading

Summary

Fixes issues related to cursor sync, position and theming. See elastic/elastic-charts#1452, elastic/elastic-charts#1447 and elastic/elastic-charts#1453.

Screen Recording 2021-11-02 at 11 40 28 AM

fixes #116754

Fixed in 7.16 in #117180

@nickofthyme nickofthyme added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 3, 2021
@nickofthyme nickofthyme mentioned this pull request Nov 3, 2021
Merged
alexwizp
alexwizp approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

stratoula
stratoula approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@nickofthyme
Copy link
Contributor Author

@elasticmachine merge upstream

@nickofthyme nickofthyme enabled auto-merge (squash) November 3, 2021 14:36
@nickofthyme nickofthyme removed the request for review from markov00 November 3, 2021 18:54
@nickofthyme nickofthyme merged commit 6fe0e50 into elastic:8.0 Nov 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 443.5KB 443.4KB -27.0B
visTypeXy 59.6KB 59.6KB -27.0B
total -54.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +3.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme deleted the fix-cursor-theme-issues-8.0 branch November 5, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickofthyme @kibanamachine @stratoula @alexwizp