-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v41.0.0 #117242
Merged
Merged
Upgrade EUI to v41.0.0 #117242
Changes from 67 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
b1fb706
eui to v41.0.0
thompsongl 86c6a08
update eui i18n tokens
thompsongl c961bc6
Merge branch 'main' into eui/41.0
thompsongl 63f993d
sass tokens
thompsongl c7047f5
EuiLoadingKibana
thompsongl d384274
EuiCodeEditor
thompsongl f1ee184
subdued
thompsongl 0fac402
betaBadgeProps
thompsongl 47c2b2e
Merge branch 'main' into eui/41.0
thompsongl b923eb2
EuiCodeEditor null-loader
thompsongl 2f97a00
src secondary -> success
thompsongl e7c0bbc
[enterprise_search] Deprecate 'secondary' color prop
cee-chen df5f2d7
[apm] Deprecate 'secondary' color prop
cee-chen 97ef934
[canvas] Deprecate 'secondary' color prop
cee-chen 623aebc
[cases] Deprecate 'secondary' color prop
cee-chen 080b0bc
[cross_cluster_replication] Deprecate 'secondary' color prop
cee-chen 6919df2
[data_enhanced] Deprecate 'secondary' color prop
cee-chen b97cd48
[data_visualizer] Deprecate 'secondary' color prop
cee-chen 1d2e2de
[fleet] Deprecate 'secondary' color prop
cee-chen 5c6e5f9
[index_management] Deprecate 'secondary' color prop
cee-chen 4533ef5
[infra] Deprecate 'secondary' color prop
cee-chen c59adc7
[ingest_pipelines] Deprecate 'secondary' color prop
cee-chen dcbbd4b
[maps] Deprecate 'secondary' color prop
cee-chen da9de20
[ml] Deprecate 'secondary' color prop
cee-chen afdca6b
[monitoring] Deprecate 'secondary' color prop
cee-chen 9d3f316
[observability] Deprecate 'secondary' color prop
cee-chen ee2f95c
[osquery] Deprecate 'secondary' color prop
cee-chen e9f93bc
[painless_lab] Deprecate 'secondary' color prop
cee-chen ab34b9f
[remote_clusters] Deprecate 'secondary' color prop
cee-chen f46fc06
[rollup] Deprecate 'secondary' color prop
cee-chen 255809a
[security] Deprecate 'secondary' color prop
cee-chen e3f7a88
[security_solution] Deprecate 'secondary' color prop
cee-chen 082738e
[snapshot_restore] Deprecate 'secondary' color prop
cee-chen 9244715
[spaces] Deprecate 'secondary' color prop
cee-chen 8c48a80
[transform] Deprecate 'secondary' color prop
cee-chen a7982e1
[triggers_actions_ui] Deprecate 'secondary' color prop
cee-chen 2b165e7
[uptime] Deprecate 'secondary' color prop
cee-chen fe6d469
[watcher] Deprecate 'secondary' color prop
cee-chen 046a94f
[infra] replace ambiguous 'secondary' color
cee-chen aac10d8
[examples] Deprecate 'secondary' color prop
cee-chen 71e0ea1
[uptime] deprecate 'subdued' prop on EuiButtonIcon
cee-chen 66ee48c
revert EuiKeyPadMenuItem betaBadge props
thompsongl d186d69
mobileOptions
thompsongl 8629fc7
Merge branch 'main' into eui/41.0
thompsongl cea0b04
examples/ updates
thompsongl ebc4907
fix brace import
thompsongl 2faa8a5
Merge branch 'main' into eui/41.0
thompsongl b428cd5
fix type exports
thompsongl 2bfc430
update expressions_explorer requiredBundles
thompsongl fc6c5b6
Merge branch 'main' into eui/41.0
thompsongl 63fda8f
remove make_id mocks
thompsongl 2866fe3
snapshot updates
thompsongl 0bb0167
fix import :facepalm:
thompsongl 8e6c433
Merge branch 'main' into eui/41.0
cee-chen b244579
Fix `ReferenceError: ace is not defined` Jest failures
cee-chen 0283ed4
Remove unused brace import (?)
cee-chen 239ea36
Fix failing Jest test due to EuiCodeEditor moving to es_ui_shared plugin
cee-chen 33537d4
Fix failing Jest test due to snapshot update
cee-chen 54b8f39
Fix failing `TypeError: Cannot read properties of undefined (reading …
cee-chen 60170a9
access uiSettings
thompsongl 1a5398d
Merge branch 'main' into eui/41.0
thompsongl 5c3ba0a
Move react-ace dependency into kbn-ui-shared-deps-npm
chandlerprall 2c75eca
Merge branch 'main' into eui/41.0
thompsongl 25e6103
Merge branch 'main' into eui/41.0
thompsongl a339b3a
Merge branch 'main' into eui/41.0
thompsongl 8c691c5
Merge branch 'main' into eui/41.0
thompsongl e150217
Merge branch 'main' into eui/41.0
thompsongl 6fdf459
Merge branch 'main' into eui/41.0
kibanamachine fd9f20d
Revert App Search shenanigans
cee-chen 2e21578
Merge branch 'main' into eui/41.0
thompsongl 5b6f387
Merge branch 'main' into eui/41.0
kibanamachine 132ec86
Merge branch 'main' into eui/41.0
thompsongl 244259a
Merge branch 'main' into eui/41.0
kibanamachine 83391cc
Merge branch 'main' into eui/41.0
kibanamachine f125834
Merge branch 'main' into eui/41.0
thompsongl 2fa3a32
secondary -> success
thompsongl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/core/public/core_app/status/components/__snapshots__/server_status.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
src/core/public/core_app/status/components/__snapshots__/status_table.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,7 +164,7 @@ describe('GET /api/status', () => { | |
since: expect.any(String), | ||
state: 'green', | ||
title: 'Green', | ||
uiColor: 'secondary', | ||
uiColor: 'success', | ||
}, | ||
statuses: [ | ||
{ | ||
|
@@ -173,23 +173,23 @@ describe('GET /api/status', () => { | |
message: 'Service is working', | ||
since: expect.any(String), | ||
state: 'green', | ||
uiColor: 'secondary', | ||
uiColor: 'success', | ||
}, | ||
{ | ||
icon: 'success', | ||
id: 'core:[email protected]', | ||
message: 'Service is working', | ||
since: expect.any(String), | ||
state: 'green', | ||
uiColor: 'secondary', | ||
uiColor: 'success', | ||
}, | ||
{ | ||
icon: 'success', | ||
id: 'plugin:[email protected]', | ||
message: 'a is available', | ||
since: expect.any(String), | ||
state: 'green', | ||
uiColor: 'secondary', | ||
uiColor: 'success', | ||
}, | ||
{ | ||
icon: 'warning', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,6 +75,6 @@ export const LICENSE_OVERRIDES = { | |
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts | ||
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint | ||
'@elastic/[email protected]': ['Elastic License 2.0'], | ||
'@elastic/eui@40.1.0': ['SSPL-1.0 OR Elastic License 2.0'], | ||
'@elastic/eui@41.0.0': ['SSPL-1.0 OR Elastic License 2.0'], | ||
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to introducing build errors when using the
es_ui_shared
import, it not longer makes sense to useEuiCodeEditor
whenCodeEditor
is the preferred component.Open to suggestions on improving this configuration from folks who have more experience using
CodeEditor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thompsongl FYI that this change is causing the failing functional test / entire expressionsExplorer page to crash:
http://localhost:5061/dev/app/expressionsExplorer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think this change was actually part of the app? It's part of
examples/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be resolved with 60170a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!