[Security Solution][Endpoint] Use a feature flag to use the new pending actions logic #117219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
pzl
reviewed
Nov 2, 2021
x-pack/plugins/security_solution/server/endpoint/services/actions.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
pzl
approved these changes
Nov 3, 2021
|
jenkins build this |
|
@elasticmachine merge upstream |
pzl
approved these changes
Nov 3, 2021
academo
approved these changes
Nov 4, 2021
`parseExperimentalConfigValue` method sets feature flag key values to `true` if passed as arg
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…ng actions logic (elastic#117219) * use a feature flag to use the new pending actions logic refs elastic/issues/116715 * switch off pending actions for endpoints when feature flag is disabled review suggestions * update/add tests to use FF * correctly override the FF `parseExperimentalConfigValue` method sets feature flag key values to `true` if passed as arg Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…ng actions logic (elastic#117219) * use a feature flag to use the new pending actions logic refs elastic/issues/116715 * switch off pending actions for endpoints when feature flag is disabled review suggestions * update/add tests to use FF * correctly override the FF `parseExperimentalConfigValue` method sets feature flag key values to `true` if passed as arg Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…ng actions logic (#117219) (#117497) * use a feature flag to use the new pending actions logic refs /issues/116715 * switch off pending actions for endpoints when feature flag is disabled review suggestions * update/add tests to use FF * correctly override the FF `parseExperimentalConfigValue` method sets feature flag key values to `true` if passed as arg Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ashokaditya <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…ng actions logic (#117219) (#117498) * use a feature flag to use the new pending actions logic refs /issues/116715 * switch off pending actions for endpoints when feature flag is disabled review suggestions * update/add tests to use FF * correctly override the FF `parseExperimentalConfigValue` method sets feature flag key values to `true` if passed as arg Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ashokaditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a feature flag to check pending actions logic. This is by default set to true for now. We might need to set it to false in case issues with cloud instances are not resolved. Then we would fall back to the old logic for showing pending actions
Checklist