Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add endpoint action response permission to defaults #117162

Closed

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Nov 2, 2021

Summary

This PR adds a new hidden index .logs-endpoint.action.responses-* to the set of default permissions to be consistent with the existing hidden index .logs-endpoint.diagnostic.collection-*.

There is a problem with Cloud instances where the permissions contained in Endpoint Security policies don't seem to be reflected in Cloud. Locally, the permissions are respected. More information here: #116715

I'm not sure if this PR fixes anything in Cloud instances, but I noticed our new index was missing and all of our older indices were included, so it seemed strange not to include .logs-endpoint.action.responses-*.

Checklist

@kevinlog kevinlog requested a review from a team as a code owner November 2, 2021 16:00
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kevinlog kevinlog added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Nov 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kevinlog kevinlog added v8.0.0 v7.16.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 2, 2021
@nchaulet
Copy link
Member

nchaulet commented Nov 2, 2021

I do not think we should move forward with that PR see #116715 (comment)

This is the default permissions we generate in case we are not able to read permissions for the package, we should be able to generate the permissions for endpoint so we probably do not need this defaults

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog closed this Nov 2, 2021
@kevinlog kevinlog deleted the task/add-response-permission-to-defaults branch November 2, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants