Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Fix regression in logging queries on inspect #117124

Merged
merged 2 commits into from
Nov 2, 2021
Merged

[Uptime] Fix regression in logging queries on inspect #117124

merged 2 commits into from
Nov 2, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes the regression which was found duing post FF testing of #112655 (comment)

It should also log queries to kibana log while also enabling the inspector panel when inspect query flag is truned fon from advanced settings for observability section.

@shahzad31 shahzad31 mentioned this pull request Nov 2, 2021
Closed
@shahzad31 shahzad31 marked this pull request as ready for review November 2, 2021 14:59
@shahzad31 shahzad31 requested a review from a team as a code owner November 2, 2021 14:59
@shahzad31 shahzad31 self-assigned this Nov 2, 2021
dominiqueclarke
dominiqueclarke approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes and removed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 2, 2021
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 2, 2021
@dominiqueclarke dominiqueclarke self-requested a review November 2, 2021 17:04
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit c91e44c into elastic:main Nov 2, 2021
@shahzad31 shahzad31 deleted the fix-regression-debug-queries branch November 2, 2021 17:44
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117124 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117124 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117124 or prevent reminders by adding the backport:skip label.

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 8, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 8, 2021
@shahzad31 @kibanamachine
[Uptime] Fix regression in logging queries on inspect (elastic#117124)
e27c87a 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 8, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 8, 2021
@shahzad31 @kibanamachine
[Uptime] Fix regression in logging queries on inspect (elastic#117124)
7d8be69 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 8, 2021
@kibanamachine @shahzad31
[Uptime] Fix regression in logging queries on inspect (#117124) (#117907
ec41e34 
)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Shahzad <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 9, 2021
@kibanamachine @shahzad31
[Uptime] Fix regression in logging queries on inspect (#117124) (#117908
d2b4da9 
)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Shahzad <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke Awaiting requested review from dominiqueclarke

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke