Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add functional tests for Field statistics embeddable in Dashboard, check for filters #116774

Merged
merged 8 commits into from
Nov 5, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Oct 29, 2021

Summary

Part of #110949 and follow up of #115644. This PR adds functional tests for Field statistics embeddable in Dashboard. Tests include:

  • Check the advanced settings to enable Field statistics table. Open Discover, the option to toggle the view mode to Field statistics should exist. When toggled, the table shows up and displays content correctly. Then save as a search.
  • Open the saved search in a new Dashboard, with the Field statistics is enabled, should display the stats table.
  • Change the advanced settings to disable the Field statistics table
  • Open the saved dashboard, the stats table should not show. Adding the saved search again should also not show the stats table.

Checklist

@qn895 qn895 changed the title [ML] Add functional tests for dashboard embeddable, filters [ML] Add functional tests for Field statistics embeddable in Dashboard, check for filters Oct 29, 2021
@qn895 qn895 self-assigned this Oct 29, 2021
@qn895 qn895 mentioned this pull request Oct 29, 2021
16 tasks
@brianseeders brianseeders changed the base branch from main to master October 29, 2021 15:16
@qn895 qn895 added test_ui_functional release_note:skip Skip the PR/issue when compiling release notes labels Oct 29, 2021
@qn895
Copy link
Member Author

qn895 commented Nov 1, 2021

@elasticmachine merge upstream

@qn895 qn895 marked this pull request as ready for review November 1, 2021 13:41
@qn895 qn895 requested a review from a team as a code owner November 1, 2021 13:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member

pheyos commented Nov 3, 2021

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Nov 3, 2021

Started flaky test suite runner ... successful after 40 tries.

@walterra walterra mentioned this pull request Nov 4, 2021
13 tasks
@qn895
Copy link
Member Author

qn895 commented Nov 5, 2021

@elasticmachine merge upstream

@qn895 qn895 added the v8.1.0 label Nov 5, 2021
@qn895 qn895 enabled auto-merge (squash) November 5, 2021 19:44
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@qn895 qn895 merged commit 6fe0052 into elastic:main Nov 5, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 5, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
…d, check for filters (elastic#116774)

* [ML] Add functional tests for dashboard embeddable, filters

* [ML] Fix permissions

* [ML] Update tests to use bulk api

* [ML] Change to constants

* [ML] Fix savedSearchTitle

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 5, 2021
…d, check for filters (#116774) (#117746)

* [ML] Add functional tests for dashboard embeddable, filters

* [ML] Fix permissions

* [ML] Update tests to use bulk api

* [ML] Change to constants

* [ML] Fix savedSearchTitle

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Quynh Nguyen <[email protected]>
@qn895 qn895 mentioned this pull request Nov 8, 2021
3 tasks
@qn895 qn895 deleted the ml-dv-func-test-filters-embeddable branch December 21, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants