[SECURITY] Copy saved object flyout should not allow copying into the active space #116657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
|
Pinging @elastic/kibana-security (Team:Security) |
|
My diligent on the stress: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2111/ |
…_space_flyout_internal
|
Result from the flakiness suite
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @XavierM |
XavierM
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2021
… active space (elastic#116657) * copy saved object flyout should not allow copying into the active space * stupid me
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2021
… active space (elastic#116657) * copy saved object flyout should not allow copying into the active space * stupid me
kibanamachine
added a commit
that referenced
this pull request
Oct 29, 2021
… active space (#116657) (#116818) * copy saved object flyout should not allow copying into the active space * stupid me Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 29, 2021
… active space (#116657) (#116817) * copy saved object flyout should not allow copying into the active space * stupid me Co-authored-by: Xavier Mouligneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fly-out should exclude the active space from the list of target spaces. If there are no target spaces, the fly-out should inform you that there are no other spaces to copy this object.
I stress out these tests but I was not able to reproduce it, I think the refactor from @jportner made these tests more stable 😍
Resolves: #116650 #96708
Checklist