[ML] Add tests for anomaly embeddables migrations #116520

qn895 · 2021-10-27T22:52:26Z

Summary

Part of #110949. This PR adds functional tests for anomaly swimlane and anomaly charts embeddable which loads a 7.15 dashboard JSON object into 8.0.0

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

qn895 · 2021-10-28T14:10:05Z

@elasticmachine merge upstream

qn895 · 2021-11-01T13:41:46Z

@elasticmachine merge upstream

elasticmachine · 2021-11-01T13:41:51Z

Pinging @elastic/ml-ui (:ml)

peteharverson · 2021-11-01T17:56:12Z

x-pack/test/functional/apps/ml/embeddables/anomaly_charts_dashboard_embeddables.ts

+
+    describe('supports migrations', function () {
+      const panelTitle = `Saved ML anomaly charts for fq_multi_1_ae`;
+      const dashboardSavedObject = {


Probably worth moving the saved object configs and then looping through each item in the list, making sure it can be loaded successfully. Then for 8.0, a 7.16 config can be added with minimal changes to the code required.

Updated here eee3561

peteharverson · 2021-11-01T17:57:46Z

x-pack/test/functional/apps/ml/embeddables/anomaly_charts_dashboard_embeddables.ts

+        await PageObjects.common.navigateToApp('dashboard');
+      });
+
+      it('loads saved dashboard from version 7.15', async () => {


Could the coreMigrationVersion from the saved object config be used in the test title?

Updated here eee3561

x-pack/test/functional/services/ml/test_resources.ts

x-pack/test/functional/apps/ml/embeddables/anomaly_embeddables_migration.ts

peteharverson

Tested locally and overall looks good. Agree with @pheyos that the step that sets the time range is unnecessary, but other than that LGTM. Just left one extra comment about a change to the test title.

peteharverson · 2021-11-02T14:23:42Z

x-pack/test/functional/apps/ml/embeddables/anomaly_embeddables_migration.ts

+
+    for (const testData of testDataList) {
+      const { dashboardSavedObject, panelTitle, type } = testData;
+      describe(`loads saved dashboard from version ${dashboardSavedObject.coreMigrationVersion}`, function () {


This same description is used for the test below. I think it would be good to include the panelTitle in the description here too.

Agreed - please let's not repeat this long title and have a shorter one for either the suite or the test.

Updated here 7e51b01

pheyos

LGTM

qn895 · 2021-11-03T15:27:40Z

@elasticmachine merge upstream

qn895 · 2021-11-03T15:33:06Z

Started flaky test suite runner ... successful in 40 runs ✅

kibanamachine · 2021-11-03T17:23:28Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #3810 succeeded 7449472
💔 Build #3722 failed 7e51b01
💚 Build #3439 succeeded c32274c
💔 Build #3416 failed eee3561
💛 Build #3202 was flaky 640b06c
💚 Build #2525 succeeded 40fe1a8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

kibanamachine · 2021-11-03T20:37:47Z

The following labels were identified as gaps in your version labels and will be added automatically:

v8.1.0

If any of these should not be on your pull request, please manually remove them.

* [ML] Add tests for anomaly charts embeddable migrations * [ML] Broaden tests for anomaly swimlane as well * [ML] Fix function rename * [ML] Update tests to use bulk api * [ML] Remove override Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-11-03T20:40:57Z

💚 Backport successful

Status	Branch	Result
✅	8.0
✅	7.16

The backport PRs will be merged automatically after passing CI.

* [ML] Add tests for anomaly charts embeddable migrations * [ML] Broaden tests for anomaly swimlane as well * [ML] Fix function rename * [ML] Update tests to use bulk api * [ML] Remove override Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Quynh Nguyen <[email protected]>

kibanamachine · 2021-11-04T20:39:49Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

* [ML] Add tests for anomaly charts embeddable migrations * [ML] Broaden tests for anomaly swimlane as well * [ML] Fix function rename * [ML] Update tests to use bulk api * [ML] Remove override Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Quynh Nguyen <[email protected]>

[ML] Add tests for anomaly charts embeddable migrations

4dc2786

Merge branch 'master' into ml-func-test-anomaly-dashboard-migrations

40fe1a8

qn895 requested a review from pheyos October 28, 2021 17:58

qn895 self-assigned this Oct 28, 2021

qn895 added :ml Feature:Anomaly Detection ML anomaly detection test_ui_functional labels Oct 28, 2021

qn895 mentioned this pull request Oct 28, 2021

[ML] Increase Test Coverage 7.16 #110949

Closed

16 tasks

Merge branch 'main' into ml-func-test-anomaly-dashboard-migrations

640b06c

qn895 marked this pull request as ready for review November 1, 2021 13:41

qn895 requested a review from a team as a code owner November 1, 2021 13:41

peteharverson reviewed Nov 1, 2021

View reviewed changes

qn895 added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Nov 1, 2021

[ML] Broaden tests for anomaly swimlane as well

eee3561

qn895 changed the title ~~[ML] Add tests for anomaly charts embeddable migrations~~ [ML] Add tests for anomalt embeddables migrations Nov 1, 2021

[ML] Fix function rename

c32274c

qn895 changed the title ~~[ML] Add tests for anomalt embeddables migrations~~ [ML] Add tests for anomaly embeddables migrations Nov 1, 2021

pheyos reviewed Nov 2, 2021

View reviewed changes

x-pack/test/functional/services/ml/test_resources.ts Outdated Show resolved Hide resolved

pheyos reviewed Nov 2, 2021

View reviewed changes

x-pack/test/functional/apps/ml/embeddables/anomaly_embeddables_migration.ts Outdated Show resolved Hide resolved

peteharverson approved these changes Nov 2, 2021

View reviewed changes

[ML] Update tests to use bulk api

7e51b01

qn895 force-pushed the ml-func-test-anomaly-dashboard-migrations branch from 4dbb311 to 7e51b01 Compare November 2, 2021 16:13

qn895 added v7.16.0 v7.16.1 labels Nov 2, 2021

[ML] Remove override

7449472

pheyos approved these changes Nov 3, 2021

View reviewed changes

Merge branch 'main' into ml-func-test-anomaly-dashboard-migrations

e2e1ae2

qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 3, 2021

qn895 merged commit 38a511b into elastic:main Nov 3, 2021

kibanamachine added the v8.1.0 label Nov 3, 2021

kibanamachine mentioned this pull request Nov 3, 2021

[8.0] [ML] Add tests for anomaly embeddables migrations (#116520) #117429

Merged

kibanamachine mentioned this pull request Nov 3, 2021

[7.16] [ML] Add tests for anomaly embeddables migrations (#116520) #117430

Merged

walterra mentioned this pull request Nov 4, 2021

[ML] Increase Test Coverage 8.1.0 #117501

Closed

13 tasks

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2021

qn895 deleted the ml-func-test-anomaly-dashboard-migrations branch November 10, 2021 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Add tests for anomaly embeddables migrations #116520

[ML] Add tests for anomaly embeddables migrations #116520

qn895 commented Oct 27, 2021 •

edited

Loading

qn895 commented Oct 28, 2021

qn895 commented Nov 1, 2021

elasticmachine commented Nov 1, 2021

peteharverson Nov 1, 2021

qn895 Nov 1, 2021

peteharverson Nov 1, 2021

qn895 Nov 1, 2021

peteharverson left a comment

peteharverson Nov 2, 2021

pheyos Nov 2, 2021

qn895 Nov 2, 2021

pheyos left a comment

qn895 commented Nov 3, 2021

qn895 commented Nov 3, 2021 •

edited

Loading

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 4, 2021

[ML] Add tests for anomaly embeddables migrations #116520

[ML] Add tests for anomaly embeddables migrations #116520

Conversation

qn895 commented Oct 27, 2021 • edited Loading

Summary

Checklist

qn895 commented Oct 28, 2021

qn895 commented Nov 1, 2021

elasticmachine commented Nov 1, 2021

peteharverson Nov 1, 2021

Choose a reason for hiding this comment

qn895 Nov 1, 2021

Choose a reason for hiding this comment

peteharverson Nov 1, 2021

Choose a reason for hiding this comment

qn895 Nov 1, 2021

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

peteharverson Nov 2, 2021

Choose a reason for hiding this comment

pheyos Nov 2, 2021

Choose a reason for hiding this comment

qn895 Nov 2, 2021

Choose a reason for hiding this comment

pheyos left a comment

Choose a reason for hiding this comment

qn895 commented Nov 3, 2021

qn895 commented Nov 3, 2021 • edited Loading

kibanamachine commented Nov 3, 2021

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

💚 Backport successful

kibanamachine commented Nov 4, 2021

qn895 commented Oct 27, 2021 •

edited

Loading

qn895 commented Nov 3, 2021 •

edited

Loading