Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix back button when adding integration from multiple integration package #116352

Merged
merged 6 commits into from
Oct 28, 2021
Merged

[Fleet] Fix back button when adding integration from multiple integration package #116352

merged 6 commits into from
Oct 28, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 26, 2021 •
edited
Loading

Description

Resolve #116244

The cancel button when adding a new integration from a package with multiple integration should redirect to the integration (AWS billing for example) and not to the main package (AWS)

How to tests

  1. Go to http://localhost:5601/app/fleet/integrations/aws-1.3.1/add-integration/billing
  2. Click on cancel you should go back to AWS Billing .

Not related
@jen-huang Did we considered saving the integration on the package policy, to allow to edit the integration and not the whole package?

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 26, 2021
@nchaulet nchaulet requested a review from a team as a code owner October 26, 2021 19:00
@nchaulet nchaulet self-assigned this Oct 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix and works as expected. 🚀

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@jen-huang
Copy link
Contributor

@jen-huang Did we considered saving the integration on the package policy, to allow to edit the integration and not the whole package?

That was not in scope at the time, no.

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet enabled auto-merge (squash) October 27, 2021 14:32
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit ede3882 into elastic:master Oct 28, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 622.2KB 622.3KB +48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2021
@nchaulet @kibanamachine
[Fleet] Fix back button when adding integration from multiple integra…
08d43fd 
…tions package (elastic#116352)
@kibanamachine kibanamachine mentioned this pull request Oct 28, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2021
@nchaulet @kibanamachine
[Fleet] Fix back button when adding integration from multiple integra…
3ccb09d 
…tions package (elastic#116352)
@kibanamachine kibanamachine mentioned this pull request Oct 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 28, 2021
@kibanamachine @nchaulet
[Fleet] Fix back button when adding integration from multiple integra…
9fca769 
…tions package (#116352) (#116535)

Co-authored-by: Nicolas Chaulet <[email protected]>
academo pushed a commit to academo/kibana that referenced this pull request Oct 28, 2021
@nchaulet
[Fleet] Fix back button when adding integration from multiple integra…
d74cbee 
…tions package (elastic#116352)
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 29, 2021
nchaulet added a commit that referenced this pull request Oct 31, 2021
@kibanamachine @nchaulet
[Fleet] Fix back button when adding integration from multiple integra…
be22d4a 
…tions package (#116352) (#116534)

Co-authored-by: Nicolas Chaulet <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 31, 2021
@amolnater-qasource
Copy link

amolnater-qasource commented Nov 11, 2021 •
edited by muskangulati-qasource
Loading

Hi @nchaulet
We are validating this PR in lieu of reported issue at #116244
We have revalidated this on latest 7.16.0 Snapshot and found it fixed now.

Observations:

  • On clicking Cancel button while adding AWS- dynamodb integration user is navigated back to dynamodb overview page.

Screen Recording:

AWS.DynamoDB.Metrics.-.Integrations.-.Elastic.-.Google.Chrome.2021-11-11.10-35-37.mp4

Build details:
Build: 45910
Commit: af229de

cc: @EricDavisX
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
6 participants
@nchaulet @elasticmachine @jen-huang @kibanamachine @amolnater-qasource @kpollich