Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Change save integration button text #116267

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[Fleet] Change save integration button text #116267

merged 1 commit into from
Oct 26, 2021

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Oct 26, 2021

Summary

Closes #116112

Change text on create package policy save button.

@hop-dev hop-dev added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 26, 2021
@hop-dev hop-dev self-assigned this Oct 26, 2021
@hop-dev hop-dev requested a review from a team as a code owner October 26, 2021 11:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hop-dev hop-dev enabled auto-merge (squash) October 26, 2021 12:55
@hop-dev hop-dev merged commit 3d47a03 into elastic:master Oct 26, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 622.1KB 622.1KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 26, 2021
@hop-dev @kibanamachine
change save integration button text (elastic#116267)
0b26f2d
@kibanamachine kibanamachine mentioned this pull request Oct 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 26, 2021
@kibanamachine @hop-dev
change save integration button text (#116267) (#116310)
f3f9d4a 
Co-authored-by: Mark Hopkin <[email protected]>
@dikshachauhan-qasource
Copy link

Hi @hop-dev

Thanks for fixing out the reported issue.

  • 'Save and Continue' button is now available on Add integration page.

Screenshot:
image

Validated on:
Version: 7.16 BC2
BUILD 45662
COMMIT ae8c5d7

Thanks
QAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@kpollich kpollich kpollich approved these changes

Assignees

@hop-dev hop-dev

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@hop-dev @elasticmachine @kibanamachine @dikshachauhan-qasource @kpollich @juliaElastic