Hide the second toast when adding a new visualization straight from dashboard #11621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
Feature:Dashboard
stacey-gammon
force-pushed
the
hide-second-toast-dashboard
branch
from
e315c41 to
103041a
Compare
kobelb
approved these changes
May 8, 2017
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
May 8, 2017
…ashboard (elastic#11621) * Hide the second toast when adding a new visualization straight from dashboard * fix tests that assume two notifications * fix another tests that assumes two toasts
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
…ashboard (elastic#11621) * Hide the second toast when adding a new visualization straight from dashboard * fix tests that assume two notifications * fix another tests that assumes two toasts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously using the
Add new visualizationbutton straight from dashboard caused two notifications to appear - one for successfully saving the visualization and one for successfully adding the visualization to the dashboard. Two were unnecessary and since our notifications move elements around, we will now only show the notification about successfully saving the visualization.