-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILM] Fixed skipped a11y and functional tests #116207
Conversation
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…rect ILM policy in the list
…rect ILM policy in the list
@elasticmachine merge upstream |
@elasticmachine merge upstrea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing those tests @yuliacech ! 👍
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* [ILM] Fixed ILM a11y test by creating a snapshot repo that is now required in the ILM API * [ILM] Fixed functional test by creating a snapshot repository * [ILM] Updated the params after es client update * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list Co-authored-by: Kibana Machine <[email protected]>
* [ILM] Fixed ILM a11y test by creating a snapshot repo that is now required in the ILM API * [ILM] Fixed functional test by creating a snapshot repository * [ILM] Updated the params after es client update * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/accessibility/apps/index_lifecycle_management.ts # x-pack/test/functional/apps/index_lifecycle_management/home_page.ts
* [ILM] Fixed skipped a11y and functional tests (#116207) * [ILM] Fixed ILM a11y test by creating a snapshot repo that is now required in the ILM API * [ILM] Fixed functional test by creating a snapshot repository * [ILM] Updated the params after es client update * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/accessibility/apps/index_lifecycle_management.ts # x-pack/test/functional/apps/index_lifecycle_management/home_page.ts * [ILM] Fixed skipped a11y and functional tests (#116207)
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
* [ILM] Fixed ILM a11y test by creating a snapshot repo that is now required in the ILM API * [ILM] Fixed functional test by creating a snapshot repository * [ILM] Updated the params after es client update * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list * [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Contributes to: elastic#194817 Why I assigned them: Assigned advanced_settings due to elastic#175255 Assigned dashboard_controls due to elastic#190797 Assigned dashboard_links due to elastic#174772 Assigned dashboard_panel_options due to elastic#178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to elastic#164341 (call site) Assigned home due to elastic#103192 Assigned index_lifecycle_management due to elastic#116207 Assigned ingest_node_pipelines due to elastic#113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to elastic#165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to elastic#195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to elastic#175893 Assigned ml_anomaly_detection due to elastic#162126 Assigned canvas due to elastic#164376 Assigned cc replication due to elastic#149069 Assigned enterpise search due to elastic#79359 Assigned graph to due elastic#190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to elastic#155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to elastic#96989 Assigned reporting due to elastic#121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to elastic#119717
## Summary Assign files within `x-pack/test/accessibility/apps/group[1|2|3]` ### Why I assigned them: Assigned advanced_settings due to #175255 Assigned dashboard_controls due to #190797 Assigned dashboard_links due to #174772 Assigned dashboard_panel_options due to #178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to #164341 (call site) Assigned home due to #103192 Assigned index_lifecycle_management due to #116207 Assigned ingest_node_pipelines due to #113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to #165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to #195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to #175893 Assigned ml_anomaly_detection due to #162126 Assigned canvas due to #164376 Assigned cc replication due to #149069 Assigned enterpise search due to #79359 Assigned graph to due #190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to #155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to #96989 Assigned reporting due to #121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to #119717 Contributes to: #194817 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Rodney Norris <[email protected]>
Fixes #114542
Fixes #114541
Fixes #114473
Fixes #114030
Summary
The ES api changed to check that the snapshot repository used in ILM actually exists. Previously, the tests didn't create a repository so some of ILM tests failed and have been skipped. This PR creates a repository before ILM a11y and functional tests and cleans it up after.