[ML] Fix Transforms not retaining _meta on clone #116206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Oct 26, 2021
darnautov
approved these changes
Oct 27, 2021
x-pack/plugins/transform/public/app/sections/create_transform/components/step_details/common.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
darnautov
added
the
auto-backport
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
* [ML] Retain _meta on clone * [ML] Fix validation on schema to only check it it's defined/not null * [ML] Remove validation because es should handle the validation already * Change type to unknown
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
* [ML] Retain _meta on clone * [ML] Fix validation on schema to only check it it's defined/not null * [ML] Remove validation because es should handle the validation already * Change type to unknown
kibanamachine
added a commit
that referenced
this pull request
Oct 28, 2021
* [ML] Retain _meta on clone * [ML] Fix validation on schema to only check it it's defined/not null * [ML] Remove validation because es should handle the validation already * Change type to unknown Co-authored-by: Quynh Nguyen <[email protected]>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
qn895
added a commit
that referenced
this pull request
Nov 1, 2021
* [ML] Retain _meta on clone * [ML] Fix validation on schema to only check it it's defined/not null * [ML] Remove validation because es should handle the validation already * Change type to unknown Co-authored-by: Quynh Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #115546 and retains the
_metafield on clone.Checklist
Delete any items that are not applicable to this PR.