[Lens] Avoid to compute over time suggestion for expensive configurations #115932

dej611 · 2021-10-21T12:58:46Z

Summary

This PR attempts to improve perceived performance of the Lens editor excluding some suggestion computation for expensive configurations.
Unit tests have been added as well.

The terms threshold hardcoded is 5 as in the issue.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

dej611 · 2021-10-21T15:01:51Z

@elasticmachine merge upstream

dej611 · 2021-10-25T08:52:25Z

@elasticmachine merge upstream

elasticmachine · 2021-10-25T12:30:02Z

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

dej611 · 2021-10-26T12:50:43Z

@elasticmachine merge upstream

mbondyra · 2021-10-27T10:30:31Z

x-pack/plugins/lens/public/indexpattern_datasource/indexpattern_suggestions.ts

@@ -21,6 +21,7 @@ import {
  getExistingColumnGroups,
  isReferenced,
  getReferencedColumnIds,
+  hasTermsFunctionWithHighSize,


nit: I am not convinced to this name, but this is the best I could come up with

Suggested change

hasTermsFunctionWithHighSize,

hasTermsWithManyBuckets,

mbondyra

Works as expected, tested on FF 🆗

dej611 · 2021-10-28T14:57:55Z

@elasticmachine merge upstream

dej611 · 2021-11-02T10:01:47Z

@elasticmachine merge upstream

dej611 · 2021-11-02T17:34:12Z

@elasticmachine merge upstream

kibanamachine · 2021-11-02T19:29:50Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	953.9KB	954.1KB	+182.0B

History

💔 Build #3679 failed be32a08
💛 Build #3537 was flaky 939c59a
💚 Build #2564 succeeded 46d57f4
💛 Build #1750 was flaky 77f31f8
💚 Build #1307 succeeded 29358e5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ions (elastic#115932) * ⚡ Avoid over time suggestion if too expensive * ✅ Add unit tests * 👌 Integrate feedback Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit eb9262d)

flash1293 · 2022-01-14T09:09:42Z

💚 All backports created successfully

Status	Branch	Result
✅	8.0
✅	7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ions (#115932) (#123020) * ⚡ Avoid over time suggestion if too expensive * ✅ Add unit tests * 👌 Integrate feedback Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit eb9262d) Co-authored-by: Marco Liberati <[email protected]>

…ions (#115932) (#123022) * ⚡ Avoid over time suggestion if too expensive * ✅ Add unit tests * 👌 Integrate feedback Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit eb9262d) Co-authored-by: Marco Liberati <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

dej611 added 2 commits October 21, 2021 14:54

⚡ Avoid over time suggestion if too expensive

5271bab

✅ Add unit tests

02d54d6

dej611 added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.1.0 labels Oct 21, 2021

Merge branch 'master' into fix/112229

e2adc70

Merge branch 'master' into fix/112229

29358e5

dej611 marked this pull request as ready for review October 25, 2021 12:29

dej611 requested a review from a team as a code owner October 25, 2021 12:30

Merge branch 'master' into fix/112229

77f31f8

mbondyra reviewed Oct 27, 2021

View reviewed changes

mbondyra approved these changes Oct 27, 2021

View reviewed changes

Merge branch 'master' into fix/112229

46d57f4

kibanamachine and others added 2 commits November 2, 2021 06:01

Merge branch 'main' into fix/112229

939c59a

👌 Integrate feedback

be32a08

Merge branch 'main' into fix/112229

7476e67

dej611 added the backport:skip This commit does not require backporting label Nov 3, 2021

dej611 merged commit eb9262d into elastic:main Nov 3, 2021

flash1293 added v7.17.0 v8.0.0 and removed backport:skip This commit does not require backporting labels Jan 14, 2022

flash1293 mentioned this pull request Jan 14, 2022

[8.0] [Lens] Avoid to compute over time suggestion for expensive configurations (#115932) #123020

Merged

flash1293 mentioned this pull request Jan 14, 2022

[7.17] [Lens] Avoid to compute over time suggestion for expensive configurations (#115932) #123022

Merged

dej611 mentioned this pull request Jun 1, 2023

[Lens] prompt user when editor performance is impacted #158321

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Avoid to compute over time suggestion for expensive configurations #115932

[Lens] Avoid to compute over time suggestion for expensive configurations #115932

dej611 commented Oct 21, 2021

dej611 commented Oct 21, 2021

dej611 commented Oct 25, 2021

elasticmachine commented Oct 25, 2021

dej611 commented Oct 26, 2021

mbondyra Oct 27, 2021 •

edited

Loading

mbondyra left a comment

dej611 commented Oct 28, 2021

dej611 commented Nov 2, 2021

dej611 commented Nov 2, 2021

kibanamachine commented Nov 2, 2021

flash1293 commented Jan 14, 2022

[Lens] Avoid to compute over time suggestion for expensive configurations #115932

[Lens] Avoid to compute over time suggestion for expensive configurations #115932

Conversation

dej611 commented Oct 21, 2021

Summary

Checklist

Risk Matrix

For maintainers

dej611 commented Oct 21, 2021

dej611 commented Oct 25, 2021

elasticmachine commented Oct 25, 2021

dej611 commented Oct 26, 2021

mbondyra Oct 27, 2021 • edited Loading

Choose a reason for hiding this comment

mbondyra left a comment

Choose a reason for hiding this comment

dej611 commented Oct 28, 2021

dej611 commented Nov 2, 2021

dej611 commented Nov 2, 2021

kibanamachine commented Nov 2, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

flash1293 commented Jan 14, 2022

💚 All backports created successfully

Questions ?

mbondyra Oct 27, 2021 •

edited

Loading