Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.16] Fix nodedetail flaky test (#115612) #115898

Merged
merged 1 commit into from
Oct 21, 2021
+7 −6
Merged

[7.16] Fix nodedetail flaky test (#115612) #115898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/monitoring/elasticsearch/node_detail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }) {
const nodesList = getService('monitoringElasticsearchNodes');
const nodeDetail = getService('monitoringElasticsearchNodeDetail');

// FLAKY https://github.com/elastic/kibana/issues/115130
describe.skip('Elasticsearch node detail', () => {
describe('Elasticsearch node detail', () => {
describe('Active Nodes', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/monitoring/elasticsearch/node_detail_mb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }) {
const nodesList = getService('monitoringElasticsearchNodes');
const nodeDetail = getService('monitoringElasticsearchNodeDetail');

// Failing: See https://github.com/elastic/kibana/issues/115255
describe.skip('Elasticsearch node detail mb', () => {
describe('Elasticsearch node detail mb', () => {
describe('Active Nodes', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

Expand Down
7 changes: 5 additions & 2 deletions x-pack/test/functional/services/monitoring/elasticsearch_nodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,11 @@ export function MonitoringElasticsearchNodesProvider({ getService, getPageObject
return pageId !== null;
}

clickRowByResolver(nodeResolver) {
return testSubjects.click(SUBJ_NODE_LINK_PREFIX + nodeResolver);
async clickRowByResolver(nodeResolver) {
await retry.waitForWithTimeout('redirection to node detail', 30000, async () => {
await testSubjects.click(SUBJ_NODE_LINK_PREFIX + nodeResolver, 5000);
return testSubjects.exists('elasticsearchNodeDetailStatus', { timeout: 5000 });
});
}

async waitForTableToFinishLoading() {
Expand Down