Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable skipped unit tests due to migration to Node 16 #115846

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Re-enable skipped unit tests due to migration to Node 16 #115846

merged 1 commit into from
Oct 21, 2021

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Oct 20, 2021 •
edited
Loading

Resolves #114776

The fix was actually done as part of https://github.com/elastic/kibana/pull/113213/files#diff-292aed65996ababbf19c9d8ff150d68d3cd5b1b670d1cceb414a4164bfca1331, so this PR un-skips the test and ensures CI passes.

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types 8.0.0 labels Oct 20, 2021
@mikecote mikecote self-assigned this Oct 20, 2021
@mikecote mikecote mentioned this pull request Oct 20, 2021
Closed
23 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

@jen-huang jen-huang added v8.0.0 and removed 8.0.0 labels Oct 20, 2021
@mikecote mikecote marked this pull request as ready for review October 21, 2021 11:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

chrisronline
chrisronline approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In the future, please try and break these large changes into smaller PRs!

@mikecote mikecote added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 21, 2021
@mikecote mikecote merged commit cc3f601 into elastic:master Oct 21, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 21, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2021
@mikecote @kibanamachine
Initial commit (elastic#115846)
524e28f
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 21, 2021
@kibanamachine @mikecote
Initial commit (#115846) (#115947)
732a342 
Co-authored-by: Mike Côté <[email protected]>
shivindera pushed a commit to shivindera/kibana that referenced this pull request Oct 25, 2021
@mikecote @shivindera
Initial commit (elastic#115846)
5827ea6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

Assignees

@mikecote mikecote

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Fix unit tests which marked as skipped or commented due to migration to Node 16.x
5 participants
@mikecote @kibanamachine @elasticmachine @chrisronline @jen-huang