-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Disable UI by default in 8.0 #115782
Conversation
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/license_management/feature_controls/license_management_security·ts.License app feature controls security global dashboard read with license_management_user [SkipCloud] global dashboard with license management user: skip cloud should render the "Stack" section with License ManagementStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/ip_array·ts.detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type ip "is" operator should filter a CIDR range of "127.0.0.4/31"Standard Out
Stack Trace
Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/ip·ts.detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type ip "is one of" operator should filter 2 ips if both are set as exceptionsStandard Out
Stack Trace
and 1 more failures, only showing the first 3. Metrics [docs]
To update your PR or re-run it, just comment with: cc @sabarasaba |
@@ -13,21 +13,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
const testSubjects = getService('testSubjects'); | |||
const retry = getService('retry'); | |||
|
|||
// Failing: See https://github.com/elastic/kibana/issues/115859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the comment since the test is meant to be skipped for 8.x
@elasticmachine merge upstream |
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @sabarasaba! Tested locally, code changes LGTM 👍
…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (347 commits) [Upgrade Assistant] Disable UI by default in 8.0 (elastic#115782) [Uptime] Added permission for new tls alert (elastic#116107) [APM] Optimize synthtrace (elastic#116091) Fix ux/apm inspector panel (elastic#116188) [RAC]: add experimental badge to alerts (elastic#116090) Unskip jest handled promise rejections (elastic#116021) [Lens] Improve tick placement for binary formatter (elastic#116158) chore: rename getApmHref to getLegacyApmHref (elastic#115689) [Security Solution] Validate ipv4/CIDR with format x.x.x.x/xx (elastic#116127) [Fleet] Use data stream name in query to get data stream info (elastic#115805) [Uptime] TLS and TLS legacy alert translation mismatch (elastic#116113) New field for integrations field (elastic#116175) Set required to false until the input is not visited (elastic#116099) Enable interactive setup by default (elastic#116141) Add not ready response to interactive setup (elastic#116138) Hide or button if needed (elastic#116124) [ML] Adding datafeed api tests (elastic#116133) Add page title to index advanced page (elastic#116134) chore: rename functions in aggregated_transactions helper (elastic#116001) Fix bug where number rendered as date (elastic#116224) ... # Conflicts: # x-pack/plugins/reporting/server/lib/screenshots/observable.ts # x-pack/plugins/reporting/server/lib/screenshots/open_url.ts
Fixes #115684
Summary
This PR disables Upgrade Assistant UI by default, since for 8.0 it isn't functional yet. I also skipped the associated tests with it since they don't need to run anymore.
How to test
yarn es snapshot --license=trial
yarn start
and navigate toStack Management
Upgrade Assistant
is not visiblexpack.upgrade_assistant.ui.enabled: true
inconfig/kibana.yml
enablesUpgrade Assistant
and the coming soon prompt is shown.