Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [TSVB] Weird state update on missing field (#115017) #115615

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

VladLasitsa
Copy link
Contributor

Backports the following commits to 7.x:

* Remove condition for index string mode when we reset field

* Fix lint

* Fix types

* Update field_select.tsx

Co-authored-by: Kibana Machine <[email protected]>
@VladLasitsa VladLasitsa enabled auto-merge (squash) October 19, 2021 17:42
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - invalid, too many tokens.

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:09:50]         └-: Machine Learning
[00:09:50]           └-> "before all" hook in "Machine Learning"
[00:09:50]           └-> "before all" hook in "Machine Learning"
[00:09:50]             │ debg creating role ft_ml_source
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:09:50]             │ debg creating role ft_ml_source_readonly
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:09:50]             │ debg creating role ft_ml_dest
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:09:50]             │ debg creating role ft_ml_dest_readonly
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:09:50]             │ debg creating role ft_ml_ui_extras
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:09:50]             │ debg creating role ft_default_space_ml_all
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:09:50]             │ debg creating role ft_default_space1_ml_all
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:09:50]             │ debg creating role ft_all_spaces_ml_all
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:09:50]             │ debg creating role ft_default_space_ml_read
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:09:50]             │ debg creating role ft_default_space1_ml_read
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:09:50]             │ debg creating role ft_all_spaces_ml_read
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:09:50]             │ debg creating role ft_default_space_ml_none
[00:09:50]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:09:50]             │ debg creating user ft_ml_poweruser
[00:09:50]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:09:50]             │ debg created user ft_ml_poweruser
[00:09:50]             │ debg creating user ft_ml_poweruser_spaces
[00:09:50]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:09:50]             │ debg created user ft_ml_poweruser_spaces
[00:09:50]             │ debg creating user ft_ml_poweruser_space1
[00:09:50]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:09:50]             │ debg created user ft_ml_poweruser_space1
[00:09:50]             │ debg creating user ft_ml_poweruser_all_spaces
[00:09:50]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:09:50]             │ debg created user ft_ml_poweruser_all_spaces
[00:09:50]             │ debg creating user ft_ml_viewer
[00:09:50]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:09:50]             │ debg created user ft_ml_viewer
[00:09:50]             │ debg creating user ft_ml_viewer_spaces
[00:09:51]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:09:51]             │ debg created user ft_ml_viewer_spaces
[00:09:51]             │ debg creating user ft_ml_viewer_space1
[00:09:51]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:09:51]             │ debg created user ft_ml_viewer_space1
[00:09:51]             │ debg creating user ft_ml_viewer_all_spaces
[00:09:51]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:09:51]             │ debg created user ft_ml_viewer_all_spaces
[00:09:51]             │ debg creating user ft_ml_unauthorized
[00:09:51]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:09:51]             │ debg created user ft_ml_unauthorized
[00:09:51]             │ debg creating user ft_ml_unauthorized_spaces
[00:09:51]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:09:51]             │ debg created user ft_ml_unauthorized_spaces
[00:14:16]           └-: jobs
[00:14:16]             └-> "before all" hook in "jobs"
[00:14:16]             └-: Categorization example endpoint - 
[00:14:16]               └-> "before all" hook for "valid with good number of tokens"
[00:14:16]               └-> "before all" hook for "valid with good number of tokens"
[00:14:16]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "mappings.json"
[00:14:16]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "data.json.gz"
[00:14:16]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [ft_categorization] creating index, cause [api], templates [], shards [1]/[0]
[00:14:16]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Created index "ft_categorization"
[00:14:16]                 │ debg [x-pack/test/functional/es_archives/ml/categorization] "ft_categorization" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:14:17]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Indexed 1501 docs into "ft_categorization"
[00:14:17]                 │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:14:17]               └-> valid with good number of tokens
[00:14:17]                 └-> "before each" hook: global before each for "valid with good number of tokens"
[00:14:17]                 └- ✓ pass  (152ms)
[00:14:17]               └-> invalid, too many tokens.
[00:14:17]                 └-> "before each" hook: global before each for "invalid, too many tokens."
[00:14:18]                 │ info [r.suppressed] [node-01] path: /_analyze, params: {}
[00:14:18]                 │      org.elasticsearch.transport.RemoteTransportException: [node-01][127.0.0.1:63131][indices:admin/analyze[s]]
[00:14:18]                 │      Caused by: java.lang.IllegalStateException: The number of tokens produced by calling _analyze has exceeded the allowed maximum of [10000]. This limit can be set by changing the [index.analyze.max_token_count] index level setting.
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.increment(TransportAnalyzeAction.java:397) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.access$100(TransportAnalyzeAction.java:387) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.simpleAnalyze(TransportAnalyzeAction.java:229) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:204) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:122) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:110) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:62) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:99) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:47) [elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:62) ~[elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:737) [elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26) [elasticsearch-7.16.0-SNAPSHOT.jar:7.16.0-SNAPSHOT]
[00:14:18]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
[00:14:18]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[00:14:18]                 │      	at java.lang.Thread.run(Thread.java:833) [?:?]
[00:14:19]                 └- ✖ fail: apis Machine Learning jobs Categorization example endpoint -  invalid, too many tokens.
[00:14:19]                 │       Error: expected 'partially_valid' to sort of equal 'invalid'
[00:14:19]                 │       + expected - actual
[00:14:19]                 │ 
[00:14:19]                 │       -partially_valid
[00:14:19]                 │       +invalid
[00:14:19]                 │       
[00:14:19]                 │       at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:14:19]                 │       at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:14:19]                 │       at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:302:44)
[00:14:19]                 │       at runMicrotasks (<anonymous>)
[00:14:19]                 │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
[00:14:19]                 │       at Object.apply (/dev/shm/workspace/parallel/13/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:14:19]                 │ 
[00:14:19]                 │ 

Stack Trace

Error: expected 'partially_valid' to sort of equal 'invalid'
    at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:302:44)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/dev/shm/workspace/parallel/13/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: 'partially_valid',
  expected: 'invalid',
  showDiff: true
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 642.3KB 642.2KB -86.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit 3276fa2 into elastic:7.x Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants