-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nodedetail flaky test #115612
Fix nodedetail flaky test #115612
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Pinging @elastic/stack-monitoring (Team:Monitoring) |
I started a new flaky test run as the one you opened had the wrong test group: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2063/. it should be xpack:ciGroup:1 |
@neptunian I saw this in your build. Still trying to figure out where to get the resulting html & png
|
Thanks @neptunian, got 5/100 failures on that run which is not encouraging. Similar failures that this change was supposed to fix - ie click on an anchor not redirecting to the page example |
Tried another approach where we retry clicking the anchor until (with a reasonable timeout) we get a redirection. Test run https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2071/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on exploration that we did today and the results of https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2071/ (failures, but on unrelated tests).
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_endpoint_exceptions·ts.detection engine api security and spaces enabled Rule exception operators for endpoints no exceptions set should find all the "hosts" from a "agent" index when no exceptions are set on the ruleStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage changes password of other user when submitting form and closes dialogStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password formStandard Out
Stack Trace
and 4 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
Single unrelated failure on this run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/79 |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
* add test-subj to page loading component * wait for page to load before navigating to node * enable node_detail functional tests * a different approach * bump timeouts * Revert "add test-subj to page loading component" This reverts commit 1840cdf. * remove unused method Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* add test-subj to page loading component * wait for page to load before navigating to node * enable node_detail functional tests * a different approach * bump timeouts * Revert "add test-subj to page loading component" This reverts commit 1840cdf. * remove unused method Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kevin Lacabane <[email protected]>
Summary
Attempt to fix flaky functional tests listed in #115408
Selenium will sometimes register a click event on an anchor with a valid href but the redirection won't happen. Given this started to occur when we toggled react mode it should be safe to assume the root cause to be in the migrated code. I couldn't find a reasonable explanation yet but it is related to the way the anchor is rendered.
This change waits until the page is fully loaded before clicking the anchor, which appears to stabilize the tests.
Additional details in #115267
Testing