Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodedetail flaky test #115612

Merged
merged 8 commits into from
Oct 21, 2021
Merged

Conversation

klacabane
Copy link
Contributor

Summary

Attempt to fix flaky functional tests listed in #115408

Selenium will sometimes register a click event on an anchor with a valid href but the redirection won't happen. Given this started to occur when we toggled react mode it should be safe to assume the root cause to be in the migrated code. I couldn't find a reasonable explanation yet but it is related to the way the anchor is rendered.

This change waits until the page is fully loaded before clicking the anchor, which appears to stabilize the tests.

Additional details in #115267

Testing

@klacabane klacabane added Team:Monitoring Stack Monitoring team v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 19, 2021
@klacabane klacabane requested a review from a team as a code owner October 19, 2021 17:19
@klacabane klacabane requested review from a team October 19, 2021 17:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@klacabane klacabane added the release_note:skip Skip the PR/issue when compiling release notes label Oct 19, 2021
@neptunian
Copy link
Contributor

neptunian commented Oct 19, 2021

I started a new flaky test run as the one you opened had the wrong test group: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2063/. it should be xpack:ciGroup:1

@matschaffer
Copy link
Contributor

matschaffer commented Oct 20, 2021

@neptunian I saw this in your build. Still trying to figure out where to get the resulting html & png

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2063/testReport/junit/Chrome%20X-Pack%20UI%20Functional%20Tests/x-pack_test_functional_apps_monitoring_elasticsearch_node_detail%C2%B7js/Kibana_Pipeline___agent_3___Monitoring_app_Elasticsearch_node_detail_Offline_Node_should_show_node_summary_of_NA_for_offline_node/

[00:08:40]               │ info Taking screenshot "/dev/shm/workspace/parallel/3/kibana/x-pack/test/functional/screenshots/failure/Monitoring app Elasticsearch node detail Offline Node should show node summary of NA for offline node.png"
[00:08:40]               │ info Current URL is: http://localhost:6131/app/monitoring#/elasticsearch/nodes?_g=(cluster_uuid:%271LYuyvCCQFS3FAO_h65PQw%27,refreshInterval:(pause:!t,value:10000),time:(from:%272017-10-06T19:53:06.748Z%27,to:%272017-10-06T20:15:30.212Z%27))
[00:08:40]               │ info Saving page source to: /dev/shm/workspace/parallel/3/kibana/x-pack/test/functional/failure_debug/html/Monitoring app Elasticsearch node detail Offline Node should show node summary of NA for offline node.html

Update: oh I found it! https://console.cloud.google.com/storage/kibana-ci-artifacts/jobs/kibana+flaky-test-suite-runner/2063/ci-worker/parallel/3/kibana/x-pack/test/functional/screenshots/failure/Monitoring%20app%20Elasticsearch%20node%20detail%20Offline%20Node%20should%20show%20node%20summary%20of%20NA%20for%20offline%20node.png

@klacabane
Copy link
Contributor Author

Thanks @neptunian, got 5/100 failures on that run which is not encouraging. Similar failures that this change was supposed to fix - ie click on an anchor not redirecting to the page example

@klacabane
Copy link
Contributor Author

klacabane commented Oct 20, 2021

Tried another approach where we retry clicking the anchor until (with a reasonable timeout) we get a redirection.

Test run https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2071/

Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on exploration that we did today and the results of https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2071/ (failures, but on unrelated tests).

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 20, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_endpoint_exceptions·ts.detection engine api security and spaces enabled Rule exception operators for endpoints no exceptions set should find all the "hosts" from a "agent" index when no exceptions are set on the rule

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: detection engine api security and spaces enabled
[00:00:00]         └-> "before all" hook in "detection engine api security and spaces enabled"
[00:00:00]         └-: 
[00:00:00]           └-> "before all" hook in ""
[00:00:22]           └-: Rule exception operators for endpoints
[00:00:22]             └-> "before all" hook in "Rule exception operators for endpoints"
[00:00:22]             └-> "before all" hook in "Rule exception operators for endpoints"
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/endpoint_without_host_type] Loading "mappings.json"
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/endpoint_without_host_type] Loading "data.json"
[00:00:22]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [endpoint_without_host_type] creating index, cause [api], templates [], shards [1]/[1]
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/endpoint_without_host_type] Created index "endpoint_without_host_type"
[00:00:22]               │ debg [x-pack/test/functional/es_archives/rule_exceptions/endpoint_without_host_type] "endpoint_without_host_type" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/endpoint_without_host_type] Indexed 4 docs into "endpoint_without_host_type"
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/agent] Loading "mappings.json"
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/agent] Loading "data.json"
[00:00:22]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [agent] creating index, cause [api], templates [], shards [1]/[1]
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/agent] Created index "agent"
[00:00:22]               │ debg [x-pack/test/functional/es_archives/rule_exceptions/agent] "agent" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:22]               │ info [x-pack/test/functional/es_archives/rule_exceptions/agent] Indexed 4 docs into "agent"
[00:00:22]             └-: no exceptions set
[00:00:22]               └-> "before all" hook for "should find all the "hosts" from a "agent" index when no exceptions are set on the rule"
[00:00:22]               └-> should find all the "hosts" from a "agent" index when no exceptions are set on the rule
[00:00:22]                 └-> "before each" hook: global before each for "should find all the "hosts" from a "agent" index when no exceptions are set on the rule"
[00:00:22]                 └-> "before each" hook for "should find all the "hosts" from a "agent" index when no exceptions are set on the rule"
[00:00:24]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.siem-signals-default]
[00:00:24]                   │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding index template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:00:24]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:00:24]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:00:24]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.lists-default]
[00:00:24]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.siem-signals-default]
[00:00:24]                   │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.items-default]
[00:00:24]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.siem-signals-default]
[00:00:24]                   │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.lists-default] for index patterns [.lists-default-*]
[00:00:24]                   │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.items-default] for index patterns [.items-default-*]
[00:00:24]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.lists-default-000001] creating index, cause [api], templates [.lists-default], shards [1]/[1]
[00:00:24]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.lists-default]
[00:00:24]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.items-default-000001] creating index, cause [api], templates [.items-default], shards [1]/[1]
[00:00:24]                 │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.lists-default]
[00:00:24]                 │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.items-default]
[00:00:24]                 │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.lists-default]
[00:00:24]                 │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.items-default]
[00:00:24]                 │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.items-default]
[00:00:28]                 │ proc [kibana] [2021-10-20T15:53:28.728+00:00][INFO ][plugins.eventLog] event logged: {"@timestamp":"2021-10-20T15:53:28.727Z","event":{"provider":"alerting","action":"execute-start","kind":"alert","category":["siem"],"start":"2021-10-20T15:53:28.727Z"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4","type_id":"siem.signals"}],"task":{"scheduled":"2021-10-20T15:53:26.619Z","schedule_delay":2108000000},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4","license":"basic","category":"siem.signals","ruleset":"siem"},"message":"alert execution start: \"dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4\"","ecs":{"version":"1.8.0"}}
[00:00:32]                 │ proc [kibana] [2021-10-20T15:53:32.699+00:00][INFO ][plugins.securitySolution] [+] Finished indexing 4  signals searched between date ranges [
[00:00:32]                 │ proc [kibana]   {
[00:00:32]                 │ proc [kibana]     "to": "2021-10-20T15:53:30.672Z",
[00:00:32]                 │ proc [kibana]     "from": "1900-01-01T00:00:00.000Z",
[00:00:32]                 │ proc [kibana]     "maxSignals": 100
[00:00:32]                 │ proc [kibana]   }
[00:00:32]                 │ proc [kibana] ] name: "Signal Testing Query" id: "dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4" rule id: "rule-1" signals index: ".siem-signals-default"
[00:00:32]                 │ proc [kibana] [2021-10-20T15:53:32.713+00:00][INFO ][plugins.eventLog] event logged: {"@timestamp":"2021-10-20T15:53:28.727Z","event":{"provider":"alerting","action":"execute","kind":"alert","category":["siem"],"start":"2021-10-20T15:53:28.727Z","outcome":"success","end":"2021-10-20T15:53:32.712Z","duration":3985000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4","type_id":"siem.signals"}],"task":{"scheduled":"2021-10-20T15:53:26.619Z","schedule_delay":2108000000},"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4","license":"basic","category":"siem.signals","ruleset":"siem","name":"Signal Testing Query"},"message":"alert executed: siem.signals:dc1cfcf0-31bd-11ec-b5a8-f307620f7ba4: 'Signal Testing Query'","ecs":{"version":"1.8.0"}}
[00:00:32]                 └- ✖ fail: detection engine api security and spaces enabled  Rule exception operators for endpoints no exceptions set should find all the "hosts" from a "agent" index when no exceptions are set on the rule
[00:00:32]                 │       Error: expected [ { os: { type: 'windows' } },
[00:00:32]                 │   { os: { type: 'macos' } },
[00:00:32]                 │   { os: { type: 'linux' } },
[00:00:32]                 │   { os: { type: 'linux' } } ] to sort of equal [ { os: { type: 'linux' } },
[00:00:32]                 │   { os: { type: 'windows' } },
[00:00:32]                 │   { os: { type: 'macos' } },
[00:00:32]                 │   { os: { type: 'linux' } } ]
[00:00:32]                 │       + expected - actual
[00:00:32]                 │ 
[00:00:32]                 │        [
[00:00:32]                 │          {
[00:00:32]                 │            "os": {
[00:00:32]                 │       -      "type": "windows"
[00:00:32]                 │       +      "type": "linux"
[00:00:32]                 │            }
[00:00:32]                 │          }
[00:00:32]                 │          {
[00:00:32]                 │            "os": {
[00:00:32]                 │       -      "type": "macos"
[00:00:32]                 │       +      "type": "windows"
[00:00:32]                 │            }
[00:00:32]                 │          }
[00:00:32]                 │          {
[00:00:32]                 │            "os": {
[00:00:32]                 │       -      "type": "linux"
[00:00:32]                 │       +      "type": "macos"
[00:00:32]                 │            }
[00:00:32]                 │          }
[00:00:32]                 │          {
[00:00:32]                 │            "os": {
[00:00:32]                 │       
[00:00:32]                 │       at Assertion.assert (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:00:32]                 │       at Assertion.eql (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:00:32]                 │       at Context.<anonymous> (test/detection_engine_api_integration/security_and_spaces/tests/create_endpoint_exceptions.ts:69:25)
[00:00:32]                 │       at runMicrotasks (<anonymous>)
[00:00:32]                 │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
[00:00:32]                 │       at Object.apply (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:00:32]                 │ 
[00:00:32]                 │ 

Stack Trace

Error: expected [ { os: { type: 'windows' } },
  { os: { type: 'macos' } },
  { os: { type: 'linux' } },
  { os: { type: 'linux' } } ] to sort of equal [ { os: { type: 'linux' } },
  { os: { type: 'windows' } },
  { os: { type: 'macos' } },
  { os: { type: 'linux' } } ]
    at Assertion.assert (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/detection_engine_api_integration/security_and_spaces/tests/create_endpoint_exceptions.ts:69:25)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '[\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "windows"\n' +
    '    }\n' +
    '  }\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "macos"\n' +
    '    }\n' +
    '  }\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "linux"\n' +
    '    }\n' +
    '  }\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "linux"\n' +
    '    }\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "linux"\n' +
    '    }\n' +
    '  }\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "windows"\n' +
    '    }\n' +
    '  }\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "macos"\n' +
    '    }\n' +
    '  }\n' +
    '  {\n' +
    '    "os": {\n' +
    '      "type": "linux"\n' +
    '    }\n' +
    '  }\n' +
    ']',
  showDiff: true
}

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage changes password of other user when submitting form and closes dialog

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115473


Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:215:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password form

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115474


Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:328:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 4 more failures, only showing the first 3.

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@klacabane
Copy link
Contributor Author

@elasticmachine merge upstream

@klacabane
Copy link
Contributor Author

Single unrelated failure on this run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/79

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@klacabane klacabane merged commit 647ca9a into elastic:master Oct 21, 2021
@klacabane klacabane deleted the fix-nodedetail-flaky-test branch October 21, 2021 08:46
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2021
* add test-subj to page loading component

* wait for page to load before navigating to node

* enable node_detail functional tests

* a different approach

* bump timeouts

* Revert "add test-subj to page loading component"

This reverts commit 1840cdf.

* remove unused method

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.16

This backport PR will be merged automatically after passing CI.

This was referenced Oct 21, 2021
kibanamachine added a commit that referenced this pull request Oct 21, 2021
* add test-subj to page loading component

* wait for page to load before navigating to node

* enable node_detail functional tests

* a different approach

* bump timeouts

* Revert "add test-subj to page loading component"

This reverts commit 1840cdf.

* remove unused method

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kevin Lacabane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Monitoring Stack Monitoring team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants