[XY] Fixes the formatting on multiple axis #115552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:XYAxis
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
mbondyra
reviewed
Oct 20, 2021
| ); | ||
| const yAxes = params.valueAxes.map((a) => { | ||
| // find the correct aspect for each value axis | ||
| const aspectsIdx = params.seriesParams.findIndex((s) => s.valueAxis === a.id); |
There was a problem hiding this comment.
nit, I find this slightly more readable but feel free to ignore :) :
const aspectY = params.seriesParams.find((s) => s.valueAxis === a.id) || aspects.y[0];
And then in the line 59 you could just do aspectY
There was a problem hiding this comment.
We can't do this unfortunately. I am retrieving the aspect idx from the seriesParams idx and then use it to retrieve the correct aspect. The params.seriesParams.find((s) => s.valueAxis === a.id) will return the seriesParam not the aspect!
There was a problem hiding this comment.
Oh ok 👌🏼 Thanks for the explanation, makes sense!
mbondyra
approved these changes
Oct 20, 2021
stratoula
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 20, 2021
* [XY] fixes the formatting on multiple axis * Move mock data to its own file
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 20, 2021
* [XY] fixes the formatting on multiple axis * Move mock data to its own file Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13866
This PR fixes a bug on the xy plugin. Specifically, it seems that when we have two metrics assigned to different axis, the format of each metric is not respected and only the formatter of the first field is taken under consideration for both axis.
This is wrong. We want this to work like lens, meaning that if we have 2 axes, each axis should have the correct format. If there are multiple metrics to the same axis then the format of the first metric is respected.
Note: the
getConfigfunction is untested, so I created a unit test in order to test the bug fix and some other cases irrelevant with this PR.I will create an issue to increase the coverage on this file as I think it calculates many important things and must be well tested.
Checklist