Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Overview page UI clean up #115258

Merged
merged 5 commits into from
Oct 18, 2021
Merged

[Upgrade Assistant] Overview page UI clean up #115258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64e0f75
- Scaling down deprecation issue panel title size to flow with typogr…
dborodyansky Oct 15, 2021
645f6a9
fix formatting
dborodyansky Oct 15, 2021
94bafee
fix i18n
dborodyansky Oct 15, 2021
02f9d69
fix formatting
dborodyansky Oct 15, 2021
2dd8a45
Merge branch '7.x' into UAtouchups
kibanamachine Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...c/application/components/overview/fix_issues_step/components/deprecation_issues_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ export const DeprecationIssuesPanel = (props: Props) => {
className="upgDeprecationIssuesPanel"
layout="horizontal"
title={deprecationSource}
titleSize="xs"
{...(!hasNoIssues && reactRouterNavigate(history, linkUrl))}
>
<EuiSpacer />
<EuiSpacer size="s"/>

{hasError ? (
<LoadingIssuesError>{errorMessage}</LoadingIssuesError>
Expand Down
27 changes: 9 additions & 18 deletions .../upgrade_assistant/public/application/components/overview/fix_logs_step/fix_logs_step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ const i18nTexts = {
identifyStepTitle: i18n.translate('xpack.upgradeAssistant.overview.identifyStepTitle', {
defaultMessage: 'Identify deprecated API use and update your applications',
}),
toggleTitle: i18n.translate('xpack.upgradeAssistant.overview.toggleTitle', {
defaultMessage: 'Log Elasticsearch deprecation issues',
}),
analyzeTitle: i18n.translate('xpack.upgradeAssistant.overview.analyzeTitle', {
defaultMessage: 'Analyze deprecation logs',
}),
Expand Down Expand Up @@ -140,21 +137,15 @@ const FixLogsStep: FunctionComponent<Props> = ({

return (
<>
<EuiText>
<h4>{i18nTexts.toggleTitle}</h4>
</EuiText>
<EuiSpacer size="m" />
<EuiPanel>
<DeprecationLoggingToggle
isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
isLoading={isLoading}
isUpdating={isUpdating}
fetchError={fetchError}
updateError={updateError}
resendRequest={resendRequest}
toggleLogging={toggleLogging}
/>
</EuiPanel>
<DeprecationLoggingToggle
isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
isLoading={isLoading}
isUpdating={isUpdating}
fetchError={fetchError}
updateError={updateError}
resendRequest={resendRequest}
toggleLogging={toggleLogging}
/>

{onlyDeprecationLogWritingEnabled && (
<>
Expand Down
2 changes: 1 addition & 1 deletion .../public/application/components/overview/migrate_system_indices/migrate_system_indices.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const MigrateSystemIndicesStep: FunctionComponent<Props> = ({ setIsComplete }) =
<EuiIcon type="check" color="success" />
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiText color="green">
<EuiText color="success">
<p>{i18nTexts.noMigrationNeeded}</p>
</EuiText>
</EuiFlexItem>
Expand Down