Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Overview page UI clean up #115258

Merged
merged 5 commits into from
Oct 18, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ export const DeprecationIssuesPanel = (props: Props) => {
className="upgDeprecationIssuesPanel"
layout="horizontal"
title={deprecationSource}
titleSize="xs"
{...(!hasNoIssues && reactRouterNavigate(history, linkUrl))}
>
<EuiSpacer />
<EuiSpacer size="s"/>

{hasError ? (
<LoadingIssuesError>{errorMessage}</LoadingIssuesError>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ const i18nTexts = {
identifyStepTitle: i18n.translate('xpack.upgradeAssistant.overview.identifyStepTitle', {
defaultMessage: 'Identify deprecated API use and update your applications',
}),
toggleTitle: i18n.translate('xpack.upgradeAssistant.overview.toggleTitle', {
defaultMessage: 'Log Elasticsearch deprecation issues',
}),
analyzeTitle: i18n.translate('xpack.upgradeAssistant.overview.analyzeTitle', {
defaultMessage: 'Analyze deprecation logs',
}),
Expand Down Expand Up @@ -140,21 +137,15 @@ const FixLogsStep: FunctionComponent<Props> = ({

return (
<>
<EuiText>
<h4>{i18nTexts.toggleTitle}</h4>
</EuiText>
<EuiSpacer size="m" />
<EuiPanel>
<DeprecationLoggingToggle
isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
isLoading={isLoading}
isUpdating={isUpdating}
fetchError={fetchError}
updateError={updateError}
resendRequest={resendRequest}
toggleLogging={toggleLogging}
/>
</EuiPanel>
<DeprecationLoggingToggle
isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
isLoading={isLoading}
isUpdating={isUpdating}
fetchError={fetchError}
updateError={updateError}
resendRequest={resendRequest}
toggleLogging={toggleLogging}
/>

{onlyDeprecationLogWritingEnabled && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const MigrateSystemIndicesStep: FunctionComponent<Props> = ({ setIsComplete }) =
<EuiIcon type="check" color="success" />
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiText color="green">
<EuiText color="success">
<p>{i18nTexts.noMigrationNeeded}</p>
</EuiText>
</EuiFlexItem>
Expand Down