[7.x] [Lens] Reference line renaming + other small fixes (#113811) #115225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🐛 Add padding to the tick label to fit threshold markers * 🐛 Better icon detection * 🐛 Fix edge cases with no title or labels * 📸 Update snapshots * ✨ Make threshold fit into view automatically * 🐛 do not compute axis threshold extends if no threshold is present * ✅ One more fix for 0-based extends and tests * ✨ Add icon placement flag * ✨ Sync padding computation with marker positioning * ✨ compute the default threshold based on data bounds * 🐛 fix duplicate suggestion issue + missing over time * 👌 Make disabled when no icon is selected * ✨ First text on marker implementation * 🐛 Fix some edge cases with auto positioning * Update x-pack/plugins/lens/public/xy_visualization/xy_config_panel/threshold_panel.tsx Co-authored-by: Michael Marcialis <[email protected]> * 🐛 Fix minor details * 💄 Small tweak * ✨ Reduce the padding if no icon is shown on the axis * 🐛 Fix color fallback for different type of layers * ✅ Fix broken unit tests * 🐛 Fix multi layer types issue * ✅ Fix test * ✅ Fix other test * 💄 Fix vertical text centering * ✨ Rename to reference lines + few fixes * 🚨 Fix linting issue * 🐛 Fix issue * 🐛 Fix computation bug for the initial static value * ✅ Add new suite of test for static value computation * 💄 Reorder panel inputs * 💄 Move styling to sass * 📝 Keeping up with the renaming * ✅ Fix functional tests after renaming * 🐛 Fix duplicate arg from conflict resolution * 👌 Integrate some follow up feedback * 📝 Fix typo * 👌 Integrate feedback * 🐛 Fix the quick functions transition bug * 🐛 Fix label issue when updating value Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Marcialis <[email protected]>
9 tasks
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @dej611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: