Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack monitoring] Remove angular #115063

Merged
merged 7 commits into from
Oct 18, 2021
Merged

[Stack monitoring] Remove angular #115063

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
988c44c
Remove angular
estermv Oct 14, 2021
e3844cf
Merge remote-tracking branch 'upstream/master' into 109791-stack-moni…
estermv Oct 15, 2021
852d8f3
Fix translations
estermv Oct 15, 2021
4ab1faa
convert insetupmode to boolean
estermv Oct 15, 2021
b33dee8
Merge remote-tracking branch 'upstream/master' into 109791-stack-moni…
estermv Oct 15, 2021
fe24e15
remove license service
estermv Oct 15, 2021
6ff9f2f
Merge branch 'master' into 109791-stack-monitoring-remove-angular
kibanamachine Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/monitoring/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
],
"server": true,
"ui": true,
"requiredBundles": ["kibanaUtils", "home", "alerting", "kibanaReact", "licenseManagement"]
"requiredBundles": ["kibanaUtils", "home", "alerting", "kibanaReact"]
}
2 changes: 1 addition & 1 deletion x-pack/plugins/monitoring/public/alerts/badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const AlertsBadge: React.FC<Props> = (props: Props) => {
const groupByType = GROUP_BY_NODE;
const panels = showByNode
? getAlertPanelsByNode(PANEL_TITLE, alerts, stateFilter)
: getAlertPanelsByCategory(PANEL_TITLE, inSetupMode, alerts, stateFilter);
: getAlertPanelsByCategory(PANEL_TITLE, !!inSetupMode, alerts, stateFilter);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious when this wouldn't be a boolean that required the !!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because of this line. In React, we default to the isInSetupMode that it's in the global state, that is marked as optional.
Should it be optional? Probably no, but I guess because of the progressive migration it didn't exist until we migrated the setup mode related stuff, so when we put it in the global state we put it as optional to not break anything that already exists.

Since, in this case, when it's undefined, we should treat it as false, I think is good enough to make the conversion here.

if (panels.length && !inSetupMode && panels[0].items) {
panels[0].items.push(
...[
Expand Down
249 changes: 0 additions & 249 deletions x-pack/plugins/monitoring/public/angular/app_modules.ts
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions x-pack/plugins/monitoring/public/angular/helpers/routes.ts
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions x-pack/plugins/monitoring/public/angular/helpers/utils.ts
View file
Open in desktop

This file was deleted.

Loading