[Stack monitoring] Fix clusters functional tests when react is enabled #114982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estermv
added
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
estermv
commented
Oct 14, 2021
| @@ -299,7 +299,7 @@ <h1 class="euiTitle euiTitle--xsmall">{{pageTitle || monitoringMain.instance}}</ | |||
| </div> | |||
|
|
|||
| <div ng-if="monitoringMain.inOverview" class="euiTabs" role="navigation"> | |||
| <a class="euiTab" data-test-subj="clusterName">{{ pageData.cluster_name }}</a> | |||
There was a problem hiding this comment.
Since the page structure is different in react and in angular, I changed the test-subj to be more specific so tests works in both versions.
neptunian
approved these changes
Oct 14, 2021
|
Will these changes fix the current failing test related to the cluster listing? https://github.com/elastic/kibana/pull/114436/checks?check_run_id=3895050323 |
@neptunian I think so, I got the same test failing locally before fixing the pathname check. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2021
elastic#114982) * Fix test subjects for overview page * fix pathname matching
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2021
#114982) (#115012) * Fix test subjects for overview page * fix pathname matching Co-authored-by: Ester Martí Vilaseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #114821
Reviewer notes
render_react_appto truenode scripts/functional_test_runner --config x-pack/test/functional/config.js --grep "Monitoring app Cluster"to execute only cluster listing and cluster overview page.