Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Workplace Search] Fix button order and remove extra source name label (#114899) #114925

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

elastic#114899)

* Remove extra source title from Personal dashboard

* Change button order to match other views

We typically have the right-most button the Save button and the reset button to the left

* Fix typo

* Fix failing test

EUI requires the name but we don’t want to dispaly it, so sending an empty string

* Remove Synchronization nav items from Custom Source

* Hide syncTriggerCallout for custom sources
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB -9.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @scottybollinger

@kibanamachine kibanamachine merged commit fbe1b58 into elastic:7.x Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants