-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified Integrations] Clean up empty states, tutorial links and routing to prefer unified integrations #114911
Merged
snide
merged 36 commits into
elastic:master
from
cchaos:integrations/update_links_and_permissions
Oct 19, 2021
Merged
Changes from 17 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
177f3d0
Completely remove Beats card
040a728
Added `category` for easily adding integration links and checking for…
3ea65dc
Example of simplified use in Security
03e8113
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide 171f889
fix links and titles to cards
snide ac836c4
empty state card updates. change add data to add integrations
snide 28c1fa3
analytics copy
snide 6384a1a
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide 7abd79f
feedback
snide 9336c01
more link and test cleanup
snide 20066a8
clean up the tutorial views and hide notices and tabs
snide 3133485
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide d237571
jest
snide e061a7a
point to obs APM agents
snide b85ec15
i18n and other test fixes
snide 013cf67
remove tests no longer needed
snide 877d4ec
more consistant copy
snide cc0aecc
Merge remote-tracking branch 'upstream/master' into integrations/upda…
joshdover c58a8fa
fix jest tests mock
snide 273552a
address feedback
snide 1a34739
feedback
snide bd68272
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine 961b599
remove data tutorial tests since tabs no longer exist
snide 8b5b576
remove directory notice components
snide 73d0e09
i18n fixes
snide c219990
a11 hack
snide a3a7125
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide 9142b85
screenreader rather than hack
snide c99e038
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide 54d9fb6
fix fleet/integrations link
snide 9b052f0
Merge remote-tracking branch 'upstream/master' into integrations/upda…
snide f56b0e8
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine 02d7b81
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine 86294f5
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine 6d3f49c
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine 1f59fe3
Merge branch 'master' into integrations/update_links_and_permissions
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,87 +35,91 @@ interface Props { | |
|
||
export const AddData: FC<Props> = ({ addBasePath, application, isDarkMode }) => { | ||
const { trackUiMetric } = getServices(); | ||
const canAccessIntegrations = application.capabilities.navLinks.integrations; | ||
if (canAccessIntegrations) { | ||
Comment on lines
+36
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like this is more of a hack than a proper usage of |
||
return ( | ||
<> | ||
<section className="homDataAdd" aria-labelledby="homDataAdd__title"> | ||
<EuiFlexGroup alignItems="flexEnd"> | ||
<EuiFlexItem> | ||
<EuiTitle size="s"> | ||
<h2 id="homDataAdd__title"> | ||
<FormattedMessage | ||
id="home.addData.sectionTitle" | ||
defaultMessage="Get started by adding integrations" | ||
/> | ||
</h2> | ||
</EuiTitle> | ||
|
||
return ( | ||
<> | ||
<section className="homDataAdd" aria-labelledby="homDataAdd__title"> | ||
<EuiFlexGroup alignItems="flexEnd"> | ||
<EuiFlexItem> | ||
<EuiTitle size="s"> | ||
<h2 id="homDataAdd__title"> | ||
<FormattedMessage | ||
id="home.addData.sectionTitle" | ||
defaultMessage="Get started by adding your data" | ||
/> | ||
</h2> | ||
</EuiTitle> | ||
<EuiSpacer /> | ||
|
||
<EuiSpacer /> | ||
<EuiText> | ||
snide marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<p> | ||
<FormattedMessage | ||
id="home.addData.text" | ||
defaultMessage="To start working with your data, use one of our many ingest options. Collect data from an app or service, or upload a file. If you're not ready to use your own data, add a sample data set." | ||
/> | ||
</p> | ||
</EuiText> | ||
|
||
<EuiText> | ||
<p> | ||
<FormattedMessage | ||
id="home.addData.text" | ||
defaultMessage="To start working with your data, use one of our many ingest options. Collect data from an app or service, or upload a file. If you're not ready to use your own data, add a sample data set." | ||
/> | ||
</p> | ||
</EuiText> | ||
<EuiSpacer /> | ||
|
||
<EuiSpacer /> | ||
<EuiFlexGroup gutterSize="m" responsive={false} wrap> | ||
<EuiFlexItem grow={false}> | ||
<RedirectAppLinks application={application}> | ||
{/* eslint-disable-next-line @elastic/eui/href-or-on-click */} | ||
<EuiButton | ||
data-test-subj="homeAddData" | ||
fill | ||
href={addBasePath('/app/integrations/browse')} | ||
iconType="plusInCircle" | ||
onClick={(event: MouseEvent) => { | ||
trackUiMetric(METRIC_TYPE.CLICK, 'home_tutorial_directory'); | ||
createAppNavigationHandler('/app/integrations/browse')(event); | ||
}} | ||
> | ||
<FormattedMessage | ||
id="home.addData.addDataButtonLabel" | ||
defaultMessage="Add integrations" | ||
/> | ||
</EuiButton> | ||
</RedirectAppLinks> | ||
</EuiFlexItem> | ||
|
||
<EuiFlexGroup gutterSize="m" responsive={false} wrap> | ||
<EuiFlexItem grow={false}> | ||
<RedirectAppLinks application={application}> | ||
{/* eslint-disable-next-line @elastic/eui/href-or-on-click */} | ||
<EuiButton | ||
data-test-subj="homeAddData" | ||
fill | ||
href={addBasePath('/app/home#/tutorial_directory')} | ||
iconType="plusInCircle" | ||
onClick={(event: MouseEvent) => { | ||
trackUiMetric(METRIC_TYPE.CLICK, 'home_tutorial_directory'); | ||
createAppNavigationHandler('/app/home#/tutorial_directory')(event); | ||
}} | ||
<EuiFlexItem grow={false}> | ||
<EuiButtonEmpty | ||
data-test-subj="addSampleData" | ||
href={addBasePath('#/tutorial_directory/sampleData')} | ||
iconType="documents" | ||
> | ||
<FormattedMessage | ||
id="home.addData.addDataButtonLabel" | ||
defaultMessage="Add your data" | ||
id="home.addData.sampleDataButtonLabel" | ||
defaultMessage="Try sample data" | ||
/> | ||
</EuiButton> | ||
</RedirectAppLinks> | ||
</EuiFlexItem> | ||
|
||
<EuiFlexItem grow={false}> | ||
<EuiButtonEmpty | ||
data-test-subj="addSampleData" | ||
href={addBasePath('#/tutorial_directory/sampleData')} | ||
iconType="documents" | ||
> | ||
<FormattedMessage | ||
id="home.addData.sampleDataButtonLabel" | ||
defaultMessage="Try sample data" | ||
/> | ||
</EuiButtonEmpty> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
</EuiFlexItem> | ||
</EuiButtonEmpty> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
</EuiFlexItem> | ||
|
||
<EuiFlexItem> | ||
<EuiImage | ||
alt="Illustration of Elastic data integrations" | ||
className="homDataAdd__illustration" | ||
src={ | ||
addBasePath('/plugins/kibanaReact/assets/') + | ||
(isDarkMode | ||
? 'illustration_integrations_darkmode.svg' | ||
: 'illustration_integrations_lightmode.svg') | ||
} | ||
/> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
</section> | ||
<EuiFlexItem> | ||
<EuiImage | ||
alt="Illustration of Elastic data integrations" | ||
className="homDataAdd__illustration" | ||
src={ | ||
addBasePath('/plugins/kibanaReact/assets/') + | ||
(isDarkMode | ||
? 'illustration_integrations_darkmode.svg' | ||
: 'illustration_integrations_lightmode.svg') | ||
} | ||
/> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
</section> | ||
|
||
<EuiHorizontalRule margin="xxl" /> | ||
</> | ||
); | ||
<EuiHorizontalRule margin="xxl" /> | ||
</> | ||
); | ||
} else { | ||
return null; | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove from the translation files (
x-pack/plugins/translations/translations
) all the keys/entries that have a change in their default message, for them to be picked for re-translation.Please double check in case I missed any, but from core's owned files:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is news to me. I thought this happened automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New keys are automatically collected. Keys that were already present in the translation files always required to be removed to be picked again. Unless I'm wrong here cc @Bamieh for confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI is failing the only requirement is to run this locally:
Retranslations and all these details are automatically handled by our scripts so devs dont have to worry about this.
The long answer is that the
--fix
removes it from the translation file if there is a difference in the passedvalues
keys.When we're about to send the labels to the translators we take the fresh messages from the source code and send the diff of the added/changed labels. Translators send us the new strings back and we integrate it back into the translations file.