Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Replace Select with GroupButtons to show available platforms #114818

Merged
merged 1 commit into from
Oct 15, 2021
Merged

[Fleet] Replace Select with GroupButtons to show available platforms #114818

merged 1 commit into from
Oct 15, 2021

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Oct 13, 2021 •
edited
Loading

Summary

Implementing #114537

This PR replaces the EuiSelect with a EuiButtonGroup to show the commands for the available platforms.
The flyout containing the component is reachable in two locations:

Location 1

  • Start kibana, go to Fleet and click on "Add agent"
  • The three options should work regularly

Add_agent

Location 2

  • Start Kibana without dataPath so you can go through the Fleet onboarding:
    yarn es snapshot -E xpack.security.authc.api_key.enabled=true -E http.host=0.0.0.0 -E
    yarn start
  • Fill out step 4 and 5 (Add host and generate a service token) and you'll get the platform options:
    Setup

Checklist

Delete any items that are not applicable to this PR.

@criamico criamico added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Oct 13, 2021
@criamico criamico self-assigned this Oct 13, 2021
@criamico criamico added the release_note:skip Skip the PR/issue when compiling release notes label Oct 13, 2021
@criamico criamico linked an issue Oct 13, 2021 that may be closed by this pull request
[Fleet UI] Add agent/Fleet server: show available platforms #114537
Closed
2 tasks
@criamico criamico force-pushed the 114537_Available_platform_enhancement branch 2 times, most recently from fea2d29 to a55f54a Compare October 13, 2021 14:24
@criamico criamico marked this pull request as ready for review October 13, 2021 14:24
@criamico criamico requested a review from a team as a code owner October 13, 2021 14:24
@criamico criamico force-pushed the 114537_Available_platform_enhancement branch from a55f54a to 132a063 Compare October 13, 2021 15:02
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico force-pushed the 114537_Available_platform_enhancement branch from 132a063 to cc41b55 Compare October 13, 2021 15:19
@jen-huang jen-huang removed the v7.15.0 label Oct 13, 2021
@criamico
Copy link
Contributor Author

jenkins, test this

@criamico criamico added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 14, 2021
nchaulet
nchaulet approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀!

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico criamico force-pushed the 114537_Available_platform_enhancement branch 2 times, most recently from 1a5693e to c78c989 Compare October 15, 2021 15:15
@jen-huang
Copy link
Contributor

Going to go ahead and merge before the weekend ;)

@jen-huang jen-huang merged commit 411886a into elastic:master Oct 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
@criamico @kibanamachine
[Fleet] Replace Select with GroupButtons to show available platforms (e…
84acef3 
…lastic#114818)
@kibanamachine kibanamachine mentioned this pull request Oct 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 635.1KB 634.8KB -332.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 105.0KB 105.4KB +398.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

kibanamachine added a commit that referenced this pull request Oct 15, 2021
@kibanamachine @criamico
[Fleet] Replace Select with GroupButtons to show available platforms (#…
8239f64 
…114818) (#115233)

Co-authored-by: Cristina Amico <[email protected]>
@criamico criamico deleted the 114537_Available_platform_enhancement branch July 12, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet UI] Add agent/Fleet server: show available platforms
5 participants
@criamico @elasticmachine @jen-huang @kibanamachine @nchaulet