Fix Canvas double render by preventing workpad and assets from being reloaded if it's already available #114712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
poffdeluxe
force-pushed
the
bug/fix-canvas-double-render
branch
2 times, most recently
from
466cdcb to
2a52e15
Compare
|
@elasticmachine merge upstream |
poffdeluxe
force-pushed
the
bug/fix-canvas-double-render
branch
from
2a52e15 to
4f1dc4b
Compare
|
@elasticmachine merge upstream |
poffdeluxe
added
the
auto-backport
poffdeluxe
force-pushed
the
bug/fix-canvas-double-render
branch
from
4f1dc4b to
deee03b
Compare
…reloaded if it's already available
poffdeluxe
force-pushed
the
bug/fix-canvas-double-render
branch
from
deee03b to
9642b86
Compare
crob611
approved these changes
Oct 19, 2021
| }, [workpadId, dispatch, setError, loadPages, workpadResolve]); | ||
|
|
||
| useEffect(() => { | ||
| (async () => { |
There was a problem hiding this comment.
Is there a reason this needs to be in an async function, vs just running synchronously?
There was a problem hiding this comment.
I'll rip this out real quick -- good catch
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 19, 2021
…reloaded if it's already available (elastic#114712) * Fix Canvas double render by preventing workpad and assets from being reloaded if it's already available * Better fix * Another fix * updating tests * updating tests again * remove unused async
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 19, 2021
…reloaded if it's already available (#114712) (#115610) * Fix Canvas double render by preventing workpad and assets from being reloaded if it's already available * Better fix * Another fix * updating tests * updating tests again * remove unused async Co-authored-by: Poff Poffenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #114340
The problem is caused by the
getRedirectPathand how it's being passed to theuseWorkpadhook. ThegetRedirectPathcallback is updated whenever a redirect happens or a page is changed within the workpad. This was causing the hook withinuseWorkpadto change since one of its dependencies (getRedirectPath) was changing and it reloaded everything on the workpad.My proposed fix here is to the useWorkpad hook into two effects:
Now, when redirect path is changed with a page update or redirect, the workpad won't be re-loaded again.