Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task manager] Remove ability to configure index #114558

Merged
merged 7 commits into from
Oct 25, 2021
Merged

[Task manager] Remove ability to configure index #114558

merged 7 commits into from
Oct 25, 2021

Conversation

chrisronline
Copy link
Contributor

Resolves #102076

@chrisronline chrisronline mentioned this pull request Oct 13, 2021
Closed
@chrisronline chrisronline marked this pull request as ready for review October 18, 2021 16:21
@chrisronline chrisronline requested review from a team as code owners October 18, 2021 16:21
@chrisronline chrisronline added Feature:Task Manager release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0 labels Oct 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

mikecote
mikecote approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changes are the same concept as #108111

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 6d6cb5c into elastic:master Oct 25, 2021
@chrisronline chrisronline deleted the task_manager/remove_index_config branch October 25, 2021 23:10
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 27, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114558 or prevent reminders by adding the backport:skip label.

@chrisronline chrisronline added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@jbudz jbudz jbudz approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[8.0 only] Remove xpack.task_manager.index setting
6 participants
@chrisronline @elasticmachine @kibanamachine @pmuellr @jbudz @mikecote