[ML] Display advanced mode toggle for the APM failed transactions table #114363
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,8 @@ import { | |
| EuiBadge, | ||
| EuiToolTip, | ||
| RIGHT_ALIGNMENT, | ||
| EuiSwitch, | ||
| EuiIconTip, | ||
| } from '@elastic/eui'; | ||
| import type { EuiTableSortingType } from '@elastic/eui/src/components/basic_table/table_types'; | ||
| import type { Direction } from '@elastic/eui/src/services/sort/sort_direction'; | ||
|
|
@@ -44,7 +46,6 @@ import { useSearchStrategy } from '../../../hooks/use_search_strategy'; | |
|
|
||
| import { ImpactBar } from '../../shared/ImpactBar'; | ||
| import { createHref, push } from '../../shared/Links/url_helpers'; | ||
|
|
||
| import { CorrelationsTable } from './correlations_table'; | ||
| import { FailedTransactionsCorrelationsHelpPopover } from './failed_transactions_correlations_help_popover'; | ||
|
|
@@ -59,6 +60,8 @@ import { CorrelationsLog } from './correlations_log'; | |
| import { CorrelationsEmptyStatePrompt } from './empty_state_prompt'; | ||
| import { CrossClusterSearchCompatibilityWarning } from './cross_cluster_search_warning'; | ||
| import { CorrelationsProgressControls } from './progress_controls'; | ||
| import { useLocalStorage } from '../../../hooks/useLocalStorage'; | ||
| import { useTheme } from '../../../hooks/use_theme'; | ||
|
|
||
| export function FailedTransactionsCorrelations({ | ||
| onFilter, | ||
|
|
@@ -91,18 +94,49 @@ export function FailedTransactionsCorrelations({ | |
| selectedSignificantTerm ?? response.failedTransactionsCorrelations?.[0]; | ||
|
|
||
| const history = useHistory(); | ||
| const [showStats, setShowStats] = useLocalStorage( | ||
| 'apmFailedTransactionsShowAdvancedStats', | ||
| false | ||
| ); | ||
| const euiTheme = useTheme(); | ||
|
|
||
| const failedTransactionsCorrelationsColumns: Array< | ||
| EuiBasicTableColumn<FailedTransactionsCorrelation> | ||
| > = useMemo(() => { | ||
| const percentageColumns: Array< | ||
| EuiBasicTableColumn<FailedTransactionsCorrelation> | ||
| > = showStats | ||
| ? [ | ||
| { | ||
| width: '100px', | ||
| field: 'pValue', | ||
| name: ( | ||
| <EuiToolTip | ||
| content={i18n.translate( | ||
| 'xpack.apm.correlations.failedTransactions.correlationsTable.pValueDescription', | ||
| { | ||
| defaultMessage: | ||
| 'The chance of getting at least this amount of field name and value for failed transactions given its prevalence in successful transactions.', | ||
| } | ||
| )} | ||
| > | ||
| <> | ||
| {i18n.translate( | ||
| 'xpack.apm.correlations.failedTransactions.correlationsTable.pValueLabel', | ||
| { | ||
| defaultMessage: 'p-value', | ||
| } | ||
| )} | ||
| <EuiIcon | ||
| size="s" | ||
| color="subdued" | ||
| type="questionInCircle" | ||
| className="eui-alignTop" | ||
| /> | ||
| </> | ||
| </EuiToolTip> | ||
| ), | ||
|
|
||
| render: (pValue: number) => pValue.toPrecision(3), | ||
| sortable: true, | ||
| }, | ||
|
|
@@ -182,7 +216,7 @@ export function FailedTransactionsCorrelations({ | |
| name: ( | ||
| <> | ||
| {i18n.translate( | ||
| 'xpack.apm.correlations.failedTransactions.correlationsTable.scoreLabel', | ||
| { | ||
| defaultMessage: 'Score', | ||
| } | ||
|
|
@@ -315,7 +349,7 @@ export function FailedTransactionsCorrelations({ | |
| }, | ||
| }, | ||
| ] as Array<EuiBasicTableColumn<FailedTransactionsCorrelation>>; | ||
| }, [history, onFilter, trackApmEvent, showStats]); | ||
|
|
||
| useEffect(() => { | ||
| if (isErrorMessage(progress.error)) { | ||
|
|
@@ -367,9 +401,6 @@ export function FailedTransactionsCorrelations({ | |
| correlationTerms.length < 1 && | ||
| (progressNormalized === 1 || !progress.isRunning); | ||
|
|
||
| const transactionDistributionChartData: TransactionDistributionChartData[] = | ||
| []; | ||
|
|
||
|
|
@@ -462,17 +493,51 @@ export function FailedTransactionsCorrelations({ | |
|
|
||
| <EuiSpacer size="s" /> | ||
|
|
||
| <EuiFlexGroup gutterSize="s" alignItems="center"> | ||
| <EuiTitle size="xs"> | ||
| <span data-test-subj="apmFailedTransactionsCorrelationsTablePanelTitle"> | ||
| {i18n.translate( | ||
| 'xpack.apm.correlations.failedTransactions.tableTitle', | ||
| { | ||
| defaultMessage: 'Correlations', | ||
| } | ||
| )} | ||
| </span> | ||
| </EuiTitle> | ||
| <EuiFlexItem | ||
| style={{ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| paddingLeft: euiTheme.eui.paddingSizes.s, | ||
| }} | ||
| > | ||
| <EuiSwitch | ||
| label={i18n.translate( | ||
| 'xpack.apm.correlations.latencyCorrelations.advancedStatisticsLabel', | ||
| { | ||
| defaultMessage: 'Advanced statistics', | ||
| } | ||
| )} | ||
| checked={showStats} | ||
| onChange={(e) => setShowStats(!showStats)} | ||
|
There was a problem hiding this comment. can you use a callback here? i.e. There was a problem hiding this comment. Unfortunately |
||
| compressed={true} | ||
|
There was a problem hiding this comment. you can leave out |
||
| /> | ||
| <EuiIconTip | ||
| size="m" | ||
| iconProps={{ | ||
| style: { marginLeft: euiTheme.eui.paddingSizes.xs }, | ||
| }} | ||
| content={i18n.translate( | ||
| 'xpack.apm.correlations.latencyCorrelations.advancedStatisticsTooltipContent', | ||
| { | ||
| defaultMessage: | ||
| 'Enable additional statistical information for the correlation results.', | ||
| } | ||
| )} | ||
| type="questionInCircle" | ||
| /> | ||
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| <EuiSpacer size="s" /> | ||
|
|
||
| <CorrelationsProgressControls | ||
|
|
@@ -490,20 +555,6 @@ export function FailedTransactionsCorrelations({ | |
| </> | ||
| )} | ||
|
|
||
| <EuiSpacer size="m" /> | ||
|
|
||
| <div data-test-subj="apmCorrelationsTable"> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qn895 @formgeist is there any value in hiding the switch when no correlations are found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peteharverson I think the result would be that the switch would come and go which can be confusing too