Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exploratory view] Render content only on expand #114237

Merged
merged 3 commits into from
Oct 12, 2021
Merged

[Exploratory view] Render content only on expand #114237

merged 3 commits into from
Oct 12, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Render expanded row content only when it's expanded.This saved us few query calls.

Though it should keep the content once it's expanded.

@shahzad31 shahzad31 requested a review from a team as a code owner October 7, 2021 08:36
@shahzad31 shahzad31 self-assigned this Oct 7, 2021
@shahzad31 shahzad31 added v7.16.0 v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed and removed v7.6.0 labels Oct 7, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 361.9KB 362.0KB +74.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@justinkambic justinkambic changed the title [Exploratory view} Render content only on expand [Exploratory view] Render content only on expand Oct 11, 2021
dominiqueclarke
dominiqueclarke approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as expected.

@shahzad31 shahzad31 merged commit df971b7 into elastic:master Oct 12, 2021
@shahzad31 shahzad31 deleted the expand-once branch October 12, 2021 14:46
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2021
@shahzad31 @kibanamachine
[Exploratory view] Render content only on expand (elastic#114237)
cd5aea3
@kibanamachine kibanamachine mentioned this pull request Oct 12, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 12, 2021
@kibanamachine @shahzad31
[Exploratory view] Render content only on expand (#114237) (#114651)
8c7d55d 
Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahzad31 @kibanamachine @dominiqueclarke