Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D/2021 10 06 try extract component from kibana react #114129

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 6, 2021

Part of #114990 -- we are going to clean up kibana_react and kibana_utils by moving shared stateless code that isn't tightly coupled to core's APIs into packages. (read on packages vs plugins)
This will potentially reduce initial page load time and also will allow for clearer code ownership.

This moves KibanaPageTemplate (the heaviest component in kibana_react) to a package going through some gaps we had with having react components in a @kbn/ package. This will serve as a blueprint for moving other smaller components.

@Dosant
Copy link
Contributor Author

Dosant commented Oct 12, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 15, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / general / should allow a user with crud privileges to attach alerts to cases.Alerts timeline Privileges: can crud should allow a user with crud privileges to attach alerts to cases

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="attach-alert-to-case-button"]`, but never found it.
    at Context.eval (http://localhost:6191/__cypress/tests?p=cypress/integration/detection_alerts/attach_to_case.spec.ts:21883:16)

Kibana Pipeline / general / should allow a user with crud privileges to attach alerts to cases.Alerts timeline Privileges: can crud should allow a user with crud privileges to attach alerts to cases

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://dryrun

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="attach-alert-to-case-button"]`, but never found it.
    at Context.eval (http://localhost:6191/__cypress/tests?p=cypress/integration/detection_alerts/attach_to_case.spec.ts:21883:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1070 1134 +64
enterpriseSearch 1546 1609 +63
home 67 138 +71
kibanaOverview 30 103 +73
kibanaReact 353 365 +12
management 35 107 +72
observability 368 432 +64
osquery 260 333 +73
securitySolution 2760 2824 +64
total +556

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/react-page-template - 24 +24
kibanaReact 260 204 -56
total -32

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +215.0B
canvas 1.0MB 1.1MB +44.3KB
enterpriseSearch 1.4MB 1.4MB +44.6KB
home 81.7KB 128.0KB +46.3KB
infra 938.5KB 938.6KB +165.0B
kibanaOverview 9.7KB 56.5KB +46.7KB
kibanaReact 203.5KB 258.7KB +55.2KB
management 8.9KB 55.4KB +46.5KB
observability 363.1KB 413.1KB +50.0KB
osquery 865.9KB 915.7KB +49.8KB
securitySolution 4.6MB 4.6MB +47.4KB
uptime 570.0KB 570.1KB +86.0B
total +431.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/react-page-template - 2 +2
core 29 28 -1
kibanaReact 5 3 -2
total -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 17.3KB 17.4KB +54.0B
home 10.0KB 10.1KB +54.0B
kibanaReact 94.2KB 57.7KB -36.4KB
observability 34.5KB 34.6KB +55.0B
osquery 7.7KB 7.7KB +54.0B
total -36.2KB
Unknown metric groups

API count

id before after diff
@kbn/react-page-template - 34 +34
kibanaReact 297 233 -64
total -30

async chunk count

id before after diff
kibanaReact 3 4 +1

miscellaneous assets size

id before after diff
canvas 0.0B 161.8KB +161.8KB
enterpriseSearch 1015.5KB 1.1MB +161.8KB
home 0.0B 161.8KB +161.8KB
kibanaOverview 0.0B 161.8KB +161.8KB
kibanaReact 68.4KB 161.8KB +93.4KB
management 0.0B 161.8KB +161.8KB
observability 0.0B 161.8KB +161.8KB
osquery 0.0B 161.8KB +161.8KB
securitySolution 326.0KB 487.8KB +161.8KB
total ⚠️ +1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants