Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] unskip the reporting funtional test #114094

Merged
merged 3 commits into from
Oct 11, 2021
Merged

[Visualize] unskip the reporting funtional test #114094

merged 3 commits into from
Oct 11, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 6, 2021 •
edited
Loading

Summary

Closes #113496

This is my second attempt to unskip these tests. I did what Lee suggests here #113520 (comment)
It seems that it stabilizes it but I am not 100% sure because in my first attempt I had also run CI multiple times and was green.

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1997/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1993/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1992/

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 labels Oct 7, 2021
@stratoula stratoula marked this pull request as ready for review October 7, 2021 06:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@stratoula stratoula requested a review from a team October 7, 2021 06:18
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only. The approach makes sense to me.

@stratoula stratoula added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 11, 2021
@stratoula stratoula merged commit 9a1779d into elastic:master Oct 11, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 11, 2021
@stratoula @kibanamachine
[Visualize] unskip the reporting funtional test (elastic#114094)
1658583 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 11, 2021
@kibanamachine @stratoula
[Visualize] unskip the reporting funtional test (#114094) (#114461)
e190acd 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Stratoula Kalafateli <[email protected]>
@flash1293 flash1293 mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.3 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@stratoula @elasticmachine @kibanamachine @flash1293