Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] De-angularize CCR pages #113988

Merged
merged 3 commits into from
Oct 6, 2021
Merged

[Stack Monitoring] De-angularize CCR pages #113988

merged 3 commits into from
Oct 6, 2021

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Oct 5, 2021 •
edited
Loading

Summary

Resolves #113808

  • CCR follower indices list view
  • CCR Shard view

Test

  • Connect your local kibana cluster to my cluster that has CCR setup (ping me for credentials). This only works until the session expires and I think you will need to connect to it before I add the remote cluster so whoever tests this will need to ping me first so I can setup an environment and then they will need to test it immediately. Alternatively you can create multiple clusters in your own cloud environment and setup CCR.
  • Navigate to Elasticsearch -> Overview -> CCR tab
  • You should see 6 follower indices with pagination of 2 pages. (Pagination in the angular version is broken, you might see 6 pages, not fixing it)
  • Clicking on a follower index will open a list of shards, there is only one shard per each index, starting with an id of 0.
  • Clicking on the shard id you should take you to the Shard page. This page has no tab navigation for whatever reason.
  • The shard view should have 2 shards and a collpased advanced section
  • Expanding the advanced section should have stats that refresh as the page data refreshes with the latest stat

@neptunian neptunian added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 5, 2021
@neptunian neptunian requested a review from a team as a code owner October 5, 2021 18:34
@neptunian neptunian requested a review from a team October 5, 2021 18:34
@neptunian neptunian self-assigned this Oct 5, 2021
@neptunian neptunian requested a review from a team October 5, 2021 18:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian neptunian added the release_note:skip Skip the PR/issue when compiling release notes label Oct 5, 2021
neptunian
neptunian commented Oct 5, 2021
View reviewed changes
x-pack/plugins/monitoring/public/components/elasticsearch/ccr_shard/ccr_shard_react.test.js
@@ -0,0 +1,82 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy over the same test for CcrShard, snapshots were identical

neptunian
neptunian commented Oct 5, 2021
View reviewed changes
x-pack/plugins/monitoring/public/components/elasticsearch/ccr_shard/ccr_shard_react.js
@@ -0,0 +1,145 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new component as CcrShard uses injector

neptunian
neptunian commented Oct 5, 2021
View reviewed changes
x-pack/plugins/monitoring/public/components/elasticsearch/ccr_shard/status.js
@@ -14,7 +14,8 @@ import { AlertsStatus } from '../../../alerts/status';

export function Status({ stat, formattedLeader, oldestStat, alerts = {} }) {
const followerIndex = stat.follower_index || get(stat, 'follower.index');
const shardId = stat.shard_id || get(stat, 'follower.shard.number');
const shardId =
Copy link
Contributor Author

@neptunian neptunian Oct 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix bug where shard with an id of 0 was evaluating as false

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@matschaffer
Copy link
Contributor

matschaffer commented Oct 6, 2021 •
edited
Loading

Testing

  • Connect your local kibana cluster to my cluster that has CCR setup (ping me for credentials) - this worked with the creds you sent me yesterday. I did have to delete .kibana* to work around a migration issue [2021-10-06T05:34:28.271+00:00][FATAL][root] [Error: [{"type":"strict_dynamic_mapping_exception","reason":"mapping set to strict, dynamic introduction of [keep_policies_up_to_date] within [epm-packages] is not allowed"}
  • Navigate to Elasticsearch -> Overview -> CCR tab
  • You should see 6 follower indices with pagination of 2 pages. (Pagination in the angular version is broken, you might see 6 pages, not fixing it)
  • Clicking on a follower index will open a list of shards, there is only one shard per each index, starting with an id of 0.
  • Clicking on the shard id you should take you to the Shard page. This page has no tab navigation for whatever reason.
  • The shard view should have 2 shard (graphs) and a collpased advanced section
  • Expanding the advanced section should have stats that refresh as the page data refreshes with the latest stat

matschaffer
matschaffer approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Awesome that you included the component test. I'll merge upstream to see if that fixes the probably-unrelated jest failure.

@matschaffer
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 634 637 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1017.6KB 1.0MB +10.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@neptunian neptunian added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 6, 2021
@neptunian neptunian merged commit 1eceef4 into elastic:master Oct 6, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
@neptunian @kibanamachine
CCR tab pages (elastic#113988)
95c9a1c 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
@kibanamachine @neptunian
CCR tab pages (#113988) (#114111)
8ca4d92 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Sandra G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

Assignees

@neptunian neptunian

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Migrate Elasticsearch CCR view to React
4 participants
@neptunian @elasticmachine @matschaffer @kibanamachine