-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] [Exploratory View] add percentile ranks, show legend always, and fix field labels #113765
[Observability] [Exploratory View] add percentile ranks, show legend always, and fix field labels #113765
Conversation
Pinging @elastic/uptime (Team:uptime) |
/oblt-deploy |
@drewpost I have not implemented any logic for updating the chart type based on selecting the percentile breakdown, or limiting chart types when the breakdown is selected. If this is desired, please let me know which chart type you'd like as default for this breakdown, and which chart types you'd like to exclude. |
4987070
to
b12e20d
Compare
'99th' as OperationType, | ||
'95th' as OperationType, | ||
'90th' as OperationType, | ||
'75th' as OperationType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add 50th as well.
@@ -572,7 +616,7 @@ export class LensAttributes { | |||
layers[layerId] = { | |||
columnOrder: [ | |||
`x-axis-column-${layerId}`, | |||
...(breakdown && sourceField !== USE_BREAK_DOWN_COLUMN | |||
...(breakdown && sourceField !== USE_BREAK_DOWN_COLUMN && breakdown !== 'percentile' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe move "percentile" into a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh, I did. I just missed this one. Thanks for catching it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and works great, thanks for doing it
@elasticmachine merge upstream |
…centile-breakdowns
@elasticmachine merge upstream |
…centile-breakdowns
@elasticmachine merge upstream |
…centile-breakdowns
…downs' of https://github.com/dominiqueclarke/kibana into feature/observability-exploratory-view-percentile-breakdowns
@elasticmachine merge upstream |
…centile-breakdowns
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/documents_source/docvalue_fields·js.maps app documents source docvalue_fields should format date fields as epoch_millis when data driven styling is applied to a date fieldStandard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
…always, and fix field labels (elastic#113765) * add percentile ranks, show legend always, and fix field labels * add 50th percentile * replace hard coded values with constant Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/observability/public/components/shared/exploratory_view/series_editor/breakdown/breakdowns.test.tsx
…always, and fix field labels (#113765) (#114848) * add percentile ranks, show legend always, and fix field labels * add 50th percentile * replace hard coded values with constant Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/observability/public/components/shared/exploratory_view/series_editor/breakdown/breakdowns.test.tsx
Summary
- Fixes #113712 Show legend always
- Fixes #113327: Resolves bug with some labels missing for certain metrics when using percentile operation/breakdowns
Testing