Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in docs & dev_docs #113746

Merged
merged 3 commits into from
Oct 7, 2021
Merged

fix typos in docs & dev_docs #113746

merged 3 commits into from
Oct 7, 2021

Conversation

garanews
Copy link
Contributor

@garanews garanews commented Oct 4, 2021

No description provided.

@garanews garanews requested a review from a team as a code owner October 4, 2021 12:16
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@juliaElastic
Copy link
Contributor

LGTM

lukeelmers
lukeelmers requested changes Oct 4, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some of these docs are generated and will need to be updated in the code itself. I've added a note with one example and some more details. Let me know if you have any questions.

docs/development/core/public/kibana-plugin-core-public.appnavoptions.euiicontype.md Show resolved Hide resolved
@lukeelmers lukeelmers added docs Team:Docs release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Oct 4, 2021
YulNaumenko
YulNaumenko approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting docs changes LGTM

@garanews garanews requested a review from a team as a code owner October 6, 2021 15:16
lukeelmers
lukeelmers approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @garanews -- changes here LGTM!

@lukeelmers
Copy link
Member

Jenkins, test this

@lukeelmers lukeelmers added auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 6, 2021
@lukeelmers lukeelmers enabled auto-merge (squash) October 6, 2021 22:01
@lukeelmers
Copy link
Member

Jenkins, test this

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukeelmers lukeelmers merged commit 58f6d90 into elastic:master Oct 7, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113746

@lukeelmers lukeelmers added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garanews @kibanamachine @juliaElastic @lukeelmers @YulNaumenko