Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fix embeddable movement on workpad in Chromium 94 #113677

Merged
merged 2 commits into from
Oct 5, 2021
Merged

[Canvas] Fix embeddable movement on workpad in Chromium 94 #113677

merged 2 commits into from
Oct 5, 2021

Conversation

poffdeluxe
Copy link
Contributor

Summary

Fixes #113295

With the latest changes to chromium, preserve-3d changes some z behavior on child elements. Since there are no Canvas elements that depend on 3D transformation, it should be safe to drop the preserve-3d setting so that it'll default to flat.

@poffdeluxe poffdeluxe added review release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Canvas v7.16.0 v7.15.1 v7.14.3 labels Oct 1, 2021
@poffdeluxe poffdeluxe requested a review from a team as a code owner October 1, 2021 21:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@poffdeluxe poffdeluxe requested a review from monfera October 1, 2021 21:15
@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB -112.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

monfera
monfera approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, elegant, minimal change 🎉

I'll report the preexisting z-order problem in a separate gh issue

@poffdeluxe poffdeluxe added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 5, 2021
@poffdeluxe poffdeluxe merged commit 5a8782b into elastic:master Oct 5, 2021
@poffdeluxe poffdeluxe deleted the bug/remove-preserve-3d-postionable branch October 5, 2021 20:27
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2021
@poffdeluxe @kibanamachine
Remove preserve-3d from Canvas positionable (elastic#113677)
2ff9157 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2021
@poffdeluxe @kibanamachine
Remove preserve-3d from Canvas positionable (elastic#113677)
8c78513 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2021
@poffdeluxe @kibanamachine
Remove preserve-3d from Canvas positionable (elastic#113677)
ce00e4e 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.15
✅ 7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 5, 2021
@kibanamachine @poffdeluxe
Remove preserve-3d from Canvas positionable (#113677) (#114008)
2c43798 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Poff Poffenberger <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 5, 2021
@kibanamachine @poffdeluxe
Remove preserve-3d from Canvas positionable (#113677) (#114009)
0183f9b 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Poff Poffenberger <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 5, 2021
@kibanamachine @poffdeluxe
Remove preserve-3d from Canvas positionable (#113677) (#114007)
67ddd49 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Poff Poffenberger <[email protected]>
@monfera monfera mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monfera monfera monfera approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:fix review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.3 v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Embeddable z-indexes broken in Chromium 94
5 participants
@poffdeluxe @elasticmachine @kibanamachine @ryankeairns @monfera