-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Migrate Index Views to React #113660
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@@ -0,0 +1,70 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the same as the original (index.js), except i'm no longer passing $scope to shardAllocation
and using shardAllocationReact
introduced in the Node view PR
|
||
export const ClusterViewReact = (props) => { | ||
return ( | ||
<table cellPadding="0" cellSpacing="0" className="table"> | ||
<TableHeadReact | ||
labels={labels.node} | ||
labels={props.labels} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be sent from the parent component (index or node pages) because they both use this component and pass in their respective labels
Testing (via docker-test-cluster)
|
For good measure I tried a relocate operation:
Here's a recording, you'll need to give it a few seconds to go blank then reload to show shard 0 on node 02 The UI did eventually update, but seemed like maybe it missed the relocating stage (just went blank for a cycle then came back as moved). It's a small index, so could be the relocating stage was too short to see, but the blank load was a little surprising. No errors in the JS console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I opened #113715 to ensure all shards states are visible. I think we can address that after feature freeze.
|
||
return ( | ||
<ItemTemplate title={title} getPageData={getPageData} id={index} pageType="indices"> | ||
<SetupModeRenderer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So weird that there's a setup mode here (that doesn't seem to do anything), but it's the same on angular so 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I was tempted to remove it. There's no action to take from what I could see.
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/custom_urls·ts.machine learning anomaly detection custom urls adds a custom URL to Dashboard in the edit job flyoutStandard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @neptunian |
@matschaffer I think I was able to reproduce the shard allocation issue in 7.15 on cloud. There were also periods of blank spaces where no nodes showed up. I never saw a relocating color. If you could confirm that with your test we could put this as a bug for later not associated with Angular removal. |
* index views * fix type Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* index views * fix type Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Sandra G <[email protected]>
Resolves #113631
Test