Reverting to legacy ES client behavior where maxSockets = Infinity #113644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏳ Build in-progress, with failures
Failed CI StepsTo update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
mshustov
reviewed
Oct 5, 2021
| @@ -59,6 +59,10 @@ export function parseClientOptions( | |||
| // do not make assumption on user-supplied data content | |||
| // fixes https://github.com/elastic/kibana/issues/101944 | |||
| disablePrototypePoisoningProtection: true, | |||
| agent: { | |||
| maxSockets: Infinity, | |||
There was a problem hiding this comment.
from #112756 (comment)
When Kibana's communication with Elasticsearch occurs over TLS, there's rather significant overhead in establishing the TLS socket.
Therefore, if there's a stampeding herd of outbound requests to Elasticsearch
we can end up in a situation where we try to create so many new TLS sockets at the same time that we end up getting TLS handshake timeouts.
In these situations, it can be beneficial to set maxSockets to a lower number,
so that we don't try to establish so many new TLS sockets and we do HTTP request queueing in Kibana.
If we expect that masxSockets: Inifinity might affect performance for a TLS connection,
maybe we can set a fixed limit for them?
agent: {
maxSockets: config.ssl ? 512 : 1024There was a problem hiding this comment.
This is why I suggested making maxSockets configurable, we don't know the optimal setting here. The optimal setting here depends on at least the following:
- long requests to Elasticsearch
- bursty behavior
- CPU speed
- operating system settings
I don't think we should artificially cap this setting to just 512 or 1024.
mshustov
reviewed
Oct 5, 2021
| @@ -59,6 +59,10 @@ export function parseClientOptions( | |||
| // do not make assumption on user-supplied data content | |||
| // fixes https://github.com/elastic/kibana/issues/101944 | |||
| disablePrototypePoisoningProtection: true, | |||
| agent: { | |||
| maxSockets: Infinity, | |||
| keepAlive: config.keepAlive, | |||
There was a problem hiding this comment.
Let's configure keepAlive fallback explicitly to avoid a situation when Kibana depends on ES client defaults
keepAlive: config.keepAlive ?? true,
mshustov
approved these changes
Oct 5, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kobelb
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2021
…lastic#113644) * Reverting to legacy ES client behavior where maxSockets = Infinity * Removing unnused type * Specifying keepAlive: true by default Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2021
…113644) (#114211) * Reverting to legacy ES client behavior where maxSockets = Infinity * Removing unnused type * Specifying keepAlive: true by default Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Brandon Kobel <[email protected]>
timroes
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #112756
"Release Note: Resolving issue where Kibana's server could only have 256 concurrent HTTP requests open to Elasticsearch before it started queueing"